Account created on 19 February 2014, over 10 years ago
  • Drupal Senior Developer at AgileanaΒ  …
#

Recent comments

πŸ‡¨πŸ‡΄Colombia sergiogsanchez

I removed the .DS_Store file and tested the assets directory import recursively

πŸ‡¨πŸ‡΄Colombia sergiogsanchez

Patch is ready for review, it should work with subdirectories and import YML valid files within those folders, it should help when your deployment shouldn't depend on the zip file and you need to update that content from time to time.

πŸ‡¨πŸ‡΄Colombia sergiogsanchez

Initial patch for bulk import of directory

πŸ‡¨πŸ‡΄Colombia sergiogsanchez

Thanks for the heads up @Deimos; I recently merged some fixes for the unit test, so I created a new one based on your patch.

πŸ‡¨πŸ‡΄Colombia sergiogsanchez

The dev version of the module should work with d10; you can find the discussion here: https://www.drupal.org/project/ldap/issues/3297516 πŸ“Œ Automated Drupal 10 compatibility fixes Fixed
a stable version probably will be released in the following weeks.

πŸ‡¨πŸ‡΄Colombia sergiogsanchez

I have tested the patch on Drupal 9.5.5, and it's working as expected skipping the user with errors or not externalauth results

πŸ‡¨πŸ‡΄Colombia sergiogsanchez

As a workaround, you could install a 1.x version of external_auth. However, I updated the library dependency and made some minor fixes for the 2.x version of the module in the patch for the D10 compatibility https://www.drupal.org/project/ldap/issues/3297516 πŸ“Œ Automated Drupal 10 compatibility fixes Fixed

πŸ‡¨πŸ‡΄Colombia sergiogsanchez

I tested it on D10 using Drupal Lenient and Ldap module with a compatibility patch for d10.

πŸ‡¨πŸ‡΄Colombia sergiogsanchez

Adding a patch with adjustments regarding to the new external auth version.

πŸ‡¨πŸ‡΄Colombia sergiogsanchez

Adding a new patch without the ci php-ldap command.

πŸ‡¨πŸ‡΄Colombia sergiogsanchez

I made a patch with the fixes for the d10 compatibility issues reported by the rector module and added the d10 readiness and the Symfony ldap library update, which is hopefully useful for d10 portability.

πŸ‡¨πŸ‡΄Colombia sergiogsanchez

Tested the patch on Drupal 9.5.3, and PHPUnit results are ok for the user processor now, I tested the user picture upload from LDAP, and it works as expected, the code standards look good to me.

πŸ‡¨πŸ‡΄Colombia sergiogsanchez

Hi, I checked the code standards on 2811663-95.patch; all the suggested strings were updated correctly according to previous comments. I tested the patch, and it works as expected on the Drupal extend page and help pages; I checked the maintainers file, test files; and comments updated.

Production build 0.69.0 2024