🇩🇪Germany @blecheimer

for me it worked (I applied it manually). I would remove the ":" after the line: "Remove upon save:"

ok, works now, also the translation. Thank you!
I'm just missing https://www.drupal.org/project/office_hours/issues/3367130 ✨ [Season] delete seasons Active for use it correctly

I have latest dev installed (Version: 8.x-1.12+39-dev)

code seems to be correct.

+1 just run into this issue....

last dev is from "last updated: 8 Nov 2023 at 13:01 UTC"
fix is not included

Ok worked, thank you!

I have 3 exception days a a count of 6 in the header

hey sorry for delay. The last dev (Last updated: 8 Nov 2023 at 13:40 CET) does not work for me. I get a WSOD.
I reverted back to working version with your patch.

yes worked after I deleted/not aplied this part:

@@ -100,6 +102,7 @@ class OfficeHoursSeason {
     if (!is_numeric($this->to)) {
       $this->to = strtotime($this->to);
     }
+dpm($this);
   }

On that note, do you see any advantage in translating the Season title/name?

for me in this case, I don't need a translation, in other cases perhaps it could be useful.

I will test it tomorrow

but don't forget, the error is only there when Seasons is enabled. what is the difference?

My guess is it always happens when a language is added to the URL.

No! My standard language is german, here is no language snippet in the url
(Try it and set NL to standard language, then the snippet disappears)

Also I don't think the Umlaut is a problem. Also not the german language but perhaps any language that is not english

Please could you tell me where the button is in the code?
and also the button of the seasons?
(File and line number?)

Ha! I've found it. it is something with the language

testspace https://master-e5ulyfnh0vsxlh4hzkzvqpvr1vy4y6tg.tugboatqa.com/de/node/2

(or try on your system:)

perhaps one thing:
enable language to german
set language german to standard and interface language.

switch to german edit interface

perhaps the other thing:
add office hours field to contenttype article.
name the field "Öffungszeiten" (machinename will be transliterated to: field_offnungzeiten)
activate the widget "Office hours (week) with exceptions and seasons" with both seasons and exceptions

now create a new article, try to add an exception. it fails.

I edit only as authenticated user

I have now disabled almost all custom modules. It is still the same.
New module list is attached.

Ok, I have tested it on the test environment with less modules than in the other drupal installation. I have the same problem there. (without Field Group https://www.drupal.org/project/field_group → and Display Suite https://www.drupal.org/project/ds →
a screenshot of the module list is attached

hi, yes I'm also using webform in this installation but not on this edit page.
ok I will test it on a test environment later.

Does this help?

Typ php
Datum Freitag, 3. November 2023 - 18:12
Standort https://---------------/node/14/edit?_wrapper_format=drupal_ajax&ajax_form=1
Referrer https://---------------/node/14/edit
Benachrichtigung LogicException: The database connection is not serializable. This probably means you are serializing an object that has an indirect reference to the database connection. Adjust your code so that is not necessary. Alternatively, look at DependencySerializationTrait as a temporary solution. in Drupal\Core\Database\Connection->__sleep() (Zeile 1712 in /------------------my host ------------------/web/core/lib/Drupal/Core/Database/Connection.php).
Schweregrad Fehler

I deleted the js-editor error because it does not is this error, it was something other in this module https://www.drupal.org/project/js_editor → . If I disable it the error with seasons is still there

When does the error appear?
when I press [Add exception]?

blecheimer → created an issue.

Thanks!

Hey, How should I give you an exact test case, please?

- Create Officehour field in Content type
- set office hours 10-18 in all day except Sa/So
- set exception days 2023-11-02 (today) and 2023-11-03 (tomorrow)

it still shows open... (see screenshot)

All caches were cleared after update

Systemname: office_hours
Version: 8.x-1.12+20-dev

Drupal-Version 10.1.5
PHP Version 8.2.11
MySQL Version 8.0.33
Apache

sorry for asking here, is this fix in the actual dev-version? it still does not work for me the status is still open even if it is an all day closed exception day

blecheimer → created an issue.

same here

Hello this patch solved my problems (described like above) please consider to apply this patch in next release