- Issue created by @johnv
- Status changed to Fixed
about 1 year ago 10:45am 7 November 2023 - 🇩🇪Germany blecheimer
I have 3 exception days a a count of 6 in the header
- 🇳🇱Netherlands johnv
That is corrected, now.
Please refetch the dev-version. - 🇩🇪Germany blecheimer
last dev is from "last updated: 8 Nov 2023 at 13:01 UTC"
fix is not included - 🇳🇱Netherlands johnv
Please check dev again. The above on-liner commit should be there and should be working.
Timezones are frustrating, so I did not bother to compare yours, mine and drupal.org's.
src/Plugin/Field/FieldWidget/OfficeHoursExceptionsWidget.php
@@ -100,7 +100,7 @@ class OfficeHoursExceptionsWidget extends OfficeHoursListWidget {
$element = [
'#type' => 'details',
'#open' => !$this->getSetting('collapsed'),
'#title' => ($count / $cardinality) . ' ' . $label,
'#field_name' => $field_name,
'#field_parents' => $form['#parents'],
] + $element;
- 🇩🇪Germany blecheimer
I have latest dev installed (Version: 8.x-1.12+39-dev)
code seems to be correct.
- 🇳🇱Netherlands johnv
Please try again.
My test case (with more than a few exceptions) gave no error.
There was 1 variable used for 2 causes, without proper initialization.
The title now also has formatPlural(): ('1 exception' vs. '2 exceptions') - 🇩🇪Germany blecheimer
ok, works now, also the translation. Thank you!
I'm just missing https://www.drupal.org/project/office_hours/issues/3367130 ✨ [Season] delete seasons Active for use it correctly Automatically closed - issue fixed for 2 weeks with no activity.