Account created on 16 October 2012, about 12 years ago
  • Lead Solution Consultant at DCXΒ  …
#

Merge Requests

Recent comments

πŸ‡¬πŸ‡§United Kingdom kolin

Tested #5 with 1.0.0-alpha12 on Drupal 10.2.4 PHP 8.2.18

πŸ‡¬πŸ‡§United Kingdom kolin

Kolin β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom kolin

I've tested this with a simple blockquote paragraph. It works as expected:

```
field_content:
plugin: html_to_paragraphs
source: body
parser:
-
plugin: html_parser_plain
tags:
- blockquote
process:
-
plugin: html_process_plain
tag: blockquote
bundle: quote
field_name: field_copy_basic
text_format: basic_rich_text
-
plugin: html_process_text
bundle: rich_text
field_name: field_rich_text
text_format: rich_text
fallback: true
```

πŸ‡¬πŸ‡§United Kingdom kolin

I've tested this patch, it works as expected.

Can we have this merged and a D10 release created, please?

πŸ‡¬πŸ‡§United Kingdom kolin

In 3.x this error is fixed by: https://www.drupal.org/project/dynamic_entity_reference/issues/3057556 πŸ› Implement EntityReferenceItemInterface Needs work

πŸ‡¬πŸ‡§United Kingdom kolin

Re-rolled the patch for the latest 2.x

πŸ‡¬πŸ‡§United Kingdom kolin

I've tested this and it works as expected

πŸ‡¬πŸ‡§United Kingdom kolin

This happens because, in a single request, we can add the same item more than once. (I think because the same URL was invalidated by multiple tags). A unique constraint would be a better solution but I didn't want to make such big changes to the module in a patch. Instead, I've checked if the item has already been added to $_items before trying to add it again.

πŸ‡¬πŸ‡§United Kingdom kolin

Kolin β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom kolin

I've tested this and it works as expected.

πŸ‡¬πŸ‡§United Kingdom kolin

We should also respect the blacklist when queueing urls for purging.
This will allow for blacklisted tags to be added when there are already items in the traffic registry.

πŸ‡¬πŸ‡§United Kingdom kolin

Kolin β†’ made their first commit to this issue’s fork.

Production build 0.71.5 2024