πŸ‡¬πŸ‡§United Kingdom @joekers

UK
Account created on 2 August 2012, over 12 years ago
  • Senior Drupal Developer at ZoochaΒ 
#

Merge Requests

Recent comments

πŸ‡¬πŸ‡§United Kingdom joekers UK

I've changed the priority to major as this issue allows users to prolong their license without renewing. Depending on the implementation, it would allow users to bypass paying for the renewal and/or retain user roles that they should no longer have.

πŸ‡¬πŸ‡§United Kingdom joekers UK

Had an issue with the latest changes not being merged in but all good now.

πŸ‡¬πŸ‡§United Kingdom joekers UK

I wanted to get this in the dev branch ready for #3161731: Add basic test coverage for the widgets and plugins β†’ so I've made the changes related to the feedback I gave.

There were a couple of items flagged by phpcs but we can fix those later.

Thanks @rahulrasgon and @jasjeet for creating and working on this issue.

πŸ‡¬πŸ‡§United Kingdom joekers UK

I've merged the MR into dev. Thanks!

πŸ‡¬πŸ‡§United Kingdom joekers UK

Thanks for raising and fixing the issue - merged into dev.

πŸ‡¬πŸ‡§United Kingdom joekers UK

joekers β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom joekers UK

PR merged into the dev release - thanks for your work on this!

πŸ‡¬πŸ‡§United Kingdom joekers UK

Great stuff! Hopefully we can make a new release soon to include it.

πŸ‡¬πŸ‡§United Kingdom joekers UK

@handkerchief could you try using the dev release and see if that fixes the issue?

The issue should've been fixed in πŸ› Configuration schema for "Enable extra settings" (title,pagination,...) incorrect Fixed

πŸ‡¬πŸ‡§United Kingdom joekers UK

Thanks for raising this issue @handkerchief. I've been able to recreate the issue and unfortunately, it's also the same for the "Offset results" and "Limit results" options.

I have a feeling it's something related to the schema updates that have been added and the field types for these options but I'm still digging into it to confirm.

πŸ‡¬πŸ‡§United Kingdom joekers UK

Thanks for raising the issue and for the fix - I've committed it to the dev branch.

Also thanks to those for testing it.

πŸ‡¬πŸ‡§United Kingdom joekers UK

Committed and created new release.

πŸ‡¬πŸ‡§United Kingdom joekers UK

Committed and created a new beta release.

πŸ‡¬πŸ‡§United Kingdom joekers UK

Patch applied to the 8.x-2.x dev branch.

πŸ‡¬πŸ‡§United Kingdom joekers UK

Thanks @ckng for the reroll - this was based on the 2890844-65.drupal.patch and now applies cleanly to 10.2.x

πŸ‡¬πŸ‡§United Kingdom joekers UK

Committed and created a new release. Thanks.

πŸ‡¬πŸ‡§United Kingdom joekers UK

Thanks @martin_klima for the info and patch - I'm in the same situation as you with tracking changes.

The patch is working well for me but the performance is a bit concerning, though it's more important that I have the messages kept as I run a set of migrations daily and need to know when there are issues.

πŸ‡¬πŸ‡§United Kingdom joekers UK

Thanks Volodymyr.I - I've committed the patch to the dev branch and will tag a new release.

πŸ‡¬πŸ‡§United Kingdom joekers UK

Thanks for reporting this issue milton_segretti - I've merged the patch in.

πŸ‡¬πŸ‡§United Kingdom joekers UK

Thanks for fixing the typos - marking RTBC

πŸ‡¬πŸ‡§United Kingdom joekers UK

I monitored Room 1 | 3.8 The Lounge

πŸ‡¬πŸ‡§United Kingdom joekers UK

I monitored Room 1 | 3.8 The Lounge

πŸ‡¬πŸ‡§United Kingdom joekers UK

I monitored Room 5 | 3.2 A & B

πŸ‡¬πŸ‡§United Kingdom joekers UK

I monitored Room 6 | 3.1 C & 3.2 C

πŸ‡¬πŸ‡§United Kingdom joekers UK

I monitored Room 6 | 3.1 C & 3.2 C

πŸ‡¬πŸ‡§United Kingdom joekers UK

I monitored Room 1 | 3.8 The Lounge

πŸ‡¬πŸ‡§United Kingdom joekers UK

Monitored Room 5 | 3.2 A & B

πŸ‡¬πŸ‡§United Kingdom joekers UK

Monitored Room 5 | 3.2 A & B

πŸ‡¬πŸ‡§United Kingdom joekers UK

I attended this

πŸ‡¬πŸ‡§United Kingdom joekers UK

The entity_value plugin here was the key for me - thanks @very_random_man!

πŸ‡¬πŸ‡§United Kingdom joekers UK

The query is also affected by this issue - when the saved search is created, the query doesn't always have the conditions applied when using a view that has AJAX enabled.

As per the comment on [3315790-4] the active query doesn't have the filter applied from the AJAX call.

πŸ‡¬πŸ‡§United Kingdom joekers UK

I've reviewed the PR and added some comments.

I've tested the patch and it works well - the onPaid event is no longer called twice.

After the changes have been made on the MR I can mark this as RTBTC.

πŸ‡¬πŸ‡§United Kingdom joekers UK

I'm not really sure what the issue with composer is but I think it's unrelated so marking as "needs review".

πŸ‡¬πŸ‡§United Kingdom joekers UK

This was a site-specific issue where access to the node was controlled in an access hook. Paragraphs checks for 'view' access on the entity and then its parent, at this point it was forbidden, and then showed empty in the REST feed.

πŸ‡¬πŸ‡§United Kingdom joekers UK

@cburschka I think what you're saying is right - the sub-module should cover entity reference revisions, however in my case, on the export nothing is printing for this type of entity. I'm not sure if it's best to create a new issue for it?

πŸ‡¬πŸ‡§United Kingdom joekers UK

Just wanted to comment in case it helps anyone else out - when using this module with the Session Limit β†’ module, the '/session-limit' path can be added so that they work together.

πŸ‡¬πŸ‡§United Kingdom joekers UK

The pass_reset_UID never seems to be in the session so this isn't working for me. Am I missing something, or maybe there was a change to core that removes it from the $_SESSION?

πŸ‡¬πŸ‡§United Kingdom joekers UK

Patch from #65 is working for me too - on 9.4.4. Cheers!

Production build 0.71.5 2024