Non-lazy ViewsReferenceFieldFormatter always sets cache max-age to 0

Looks like this regression was introduced in 🐛 Cache metadata is not captured when no results Fixed

Thanks for raising and fixing the issue - merged into dev.

I have not tested, but the change looks reasonable to me.
I assume/hope the render element will contain all the necessary cache metadata, even on empty result.

Sorry for changing the status!

Yep it takes all attributes of the #cache key, in the same way that add cacheable dependency does so if the view returns a max age of zero like the original issue re no results, that will be carried across into the $elements render array.

Thanks for actioning this so quickly by the way, much appreciated! Was a bit worried about some higher traffic sites taking a performance hit.

@scott_euser
Could we come up with a testing scenario to confirm that this works correctly on a given website?

Yeah we would just render a view programmatically and check cacheability then again same view but via views reference field formatter. But this module has very little test coverage as it is, so really it's part of a much bigger job.

Automatically closed - issue fixed for 2 weeks with no activity.