A bug has come to our attention: if a customer adds a license to their cart, the existing license will never expire and the customer's roles will not be revoked.
drush eval "Drupal::service('commerce_license.cron')->run()";
drush advancedqueue:queue:process commerce_license;Expected result: the license will expire and roles revoked.
Actual result: nothing happens, the user keep their roles.
That's because the license cannot transit from renewal_in_progress to expire, only from active to expire.
Which is strange, because LicenseExpire.php suggests it should allow such transition.
I would suggest updating the workflow to enable this transition.
Active
3.0
Code
Alternatively we could update LicenseExpire.php to activate the license before expiring it ...
I've changed the priority to major as this issue allows users to prolong their license without renewing. Depending on the implementation, it would allow users to bypass paying for the renewal and/or retain user roles that they should no longer have.