Recent comments

🇦🇺Australia gigimaor Narangba/Brisbane

I found that Drupal\Tests\token\Kernel\KernelTestBase is deprecated.
the issue was fixed when using Drupal\Tests\token\Kernel\TokenKernelTestBase instead.

🇦🇺Australia gigimaor Narangba/Brisbane
🇦🇺Australia gigimaor Narangba/Brisbane
🇦🇺Australia gigimaor Narangba/Brisbane
🇦🇺Australia gigimaor Narangba/Brisbane

In case a website has a subdirectory to its path (base_path()), we would like to include it in the path
https://www.website.com/subdirectory/...

🇦🇺Australia gigimaor Narangba/Brisbane

This patch fixes this error:

Incompatible module
The following module is installed, but it is incompatible with Drupal 10.2.5: Display Machine Name

Review the suggestions for resolving this incompatibility to repair your installation, and then re-run update.php.

🇦🇺Australia gigimaor Narangba/Brisbane

I am experiencing the same issue as ticket #54.
I followed up on #15 and found the issue pretty quickly.

🇦🇺Australia gigimaor Narangba/Brisbane

Thank you Lee
In my case, the configurations are being ignored, and our Drupal is used on multiple websites. Some of them might return errors after the upgrade.
I suggest manually deselecting the node bundle, before the upgrade, and selecting a different visibility solution instead. Missing doing that could cause a cross-website error.

I used a post-update function to migrate all node types to bundle:node, as Lee suggested above, to run it during the upgrade deployment process or after.

/**
 * Fix script_manager module node_type issue.
 *
 */
function ua_post_update_script_manager_node_type(){
  // Fix script manager settings.
  $config_factory = \Drupal::service('config.factory');
  $script_manager_settings = $config_factory->listAll('script_manager.settings');
  $config = $config_factory->getEditable($script_manager_settings[0]);
  $enabled_visibility_plugins = $config->get('enabled_visibility_plugins');
  if (is_array($enabled_visibility_plugins)) {
    $enabled_visibility_plugins = array_replace($enabled_visibility_plugins,
      array_fill_keys(
        array_keys($enabled_visibility_plugins, 'node_type'),
        'entity_bundle:node'
      )
    );
    $config->set('enabled_visibility_plugins', $enabled_visibility_plugins);
    $config->save();
  }
  // Fix script manager items.
  $config_factory = \Drupal::service('config.factory');
  $script_manager_configurations  = $config_factory->listAll('script_manager.script');
  foreach ($script_manager_configurations as $config_name) {
    // Load the block configuration.
    $config = $config_factory->getEditable($config_name);

    // Check for a value and update it if needed.
    if (is_array($config->get('visibility.node_type'))) {
      if ($config->get('visibility.node_type')['id'] === 'node_type') {
        $config->set('visibility.node_type.id', 'entity_bundle:node');
        $config->save();
      }
    }
  }
}

🇦🇺Australia gigimaor Narangba/Brisbane

The source of my issue fixed in this patch

🇦🇺Australia gigimaor Narangba/Brisbane

In my case, after updating the core version to 10.2.2
In /admin/config/people/accounts

TypeError: Symfony\Component\HttpFoundation\InputBag::get(): Argument #1 ($key) must be of type string, null given, called in /code/web/core/lib/Drupal/Core/Routing/RouteMatch.php on line 127 in Symfony\Component\HttpFoundation\InputBag->get() (line 29 of /code/vendor/symfony/http-foundation/InputBag.php).
Drupal\Core\Routing\RouteMatch->getRawParameter() (Line: 61)
Drupal\workflow_field_groups\Access\WorkflowFieldGroupsAccessCheck->access()
call_user_func_array() (Line: 160)
Drupal\Core\Access\AccessManager->performCheck() (Line: 136)
Drupal\Core\Access\AccessManager->check() (Line: 93)
...

In my case, it is caused by a module that is not supported anymore but is still in use: workflow_field_groups

On this line web/core/lib/Drupal/Core/Routing/RouteMatch.php on line 127 $parameter_name is NULL

  public function getParameter($parameter_name) {
    return $this->parameters->get($parameter_name);
  }

Preventing this from happening could be done by patching this line
return $this->parameters->get($parameter_name);
to this
return $this->parameters->get($parameter_name ?? '');

🇦🇺Australia gigimaor Narangba/Brisbane

Suggestion solution

🇦🇺Australia gigimaor Narangba/Brisbane

Suggestion to upgrade patch to support v3.0

The redirect form could be in the client edit form.

🇦🇺Australia gigimaor Narangba/Brisbane

PDF render the form elements instead of the elements' values.

Module hooks are not compatible:
hook_field_widget_WIDGET_TYPE_form_alter should be hook_field_widget_single_element_WIDGET_TYPE_form_alter

🇦🇺Australia gigimaor Narangba/Brisbane

This patch works for me on Drupal 10

🇦🇺Australia gigimaor Narangba/Brisbane

The idea of this patch is to have the option to have the logout page as part of the configuration files to save in repo without the needs to create a specific node for the logout page.

This patch is an update for version 1.3 and works well in Drupal 10.

🇦🇺Australia gigimaor Narangba/Brisbane

This one is working for me after upgrading to Drupal 10.

🇦🇺Australia gigimaor Narangba/Brisbane

gigimaor created an issue.

🇦🇺Australia gigimaor Narangba/Brisbane

gigimaor created an issue.

🇦🇺Australia gigimaor Narangba/Brisbane

Still getting error

TypeError: count(): Argument #1 ($value) must be of type Countable|array, string given in controlled_fields_check_access() (line 608 of /code/web/modules/contrib/controlled_fields/controlled_fields.module)
#0 /code/web/modules/contrib/controlled_fields/controlled_fields.module(600): controlled_fields_check_access()
#1 /code/web/modules/contrib/controlled_fields/controlled_fields.module(678): controlled_fields_check_access()
#2 /code/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(562): controlled_fields_entity_print_form_content_alter()
#3 /code/web/modules/contrib/entity_print_form/src/Service/PrintFormBuilder.php(198): Drupal\Core\Extension\ModuleHandler->alter()
#4 /code/web/modules/contrib/entity_print_form/src/Service/PrintFormBuilder.php(121): Drupal\entity_print_form\Service\PrintFormBuilder->generateHtml()
#5 /code/web/modules/contrib/entity_print_form/src/Plugin/Action/EFormSubmissionViewFormPdf.php(50): Drupal\entity_print_form\Service\PrintFormBuilder->deliverPrintable()
#6 /code/vendor/symfony/http-foundation/StreamedResponse.php(112): Drupal\entity_print_form\Plugin\Action\EFormSubmissionViewFormPdf->Drupal\entity_print_form\Plugin\Action\{closure}()
#7 /code/vendor/symfony/http-foundation/Response.php(381): Symfony\Component\HttpFoundation\StreamedResponse->sendContent()
#8 /code/web/modules/contrib/entity_print_form/src/Plugin/Action/EFormSubmissionViewFormPdf.php(51): Symfony\Component\HttpFoundation\Response->send()
#9 /code/web/core/lib/Drupal/Core/Action/ActionBase.php(22): Drupal\entity_print_form\Plugin\Action\EFormSubmissionViewFormPdf->execute()
#10 /code/web/core/modules/system/src/Entity/Action.php(129): Drupal\Core\Action\ActionBase->executeMultiple()
#11 /code/web/core/modules/views/src/Plugin/views/field/BulkForm.php(415): Drupal\system\Entity\Action->execute()
#12 /code/web/core/modules/views/src/Form/ViewsFormMainForm.php(183): Drupal\views\Plugin\views\field\BulkForm->viewsFormSubmit()
#13 /code/web/core/modules/views/src/Form/ViewsForm.php(190): Drupal\views\Form\ViewsFormMainForm->submitForm()
#14 [internal function]: Drupal\views\Form\ViewsForm->submitForm()
#15 /code/web/core/lib/Drupal/Core/Form/FormSubmitter.php(114): call_user_func_array()
#16 /code/web/core/lib/Drupal/Core/Form/FormSubmitter.php(52): Drupal\Core\Form\FormSubmitter->executeSubmitHandlers()
#17 /code/web/core/lib/Drupal/Core/Form/FormBuilder.php(595): Drupal\Core\Form\FormSubmitter->doSubmitForm()
#18 /code/web/core/lib/Drupal/Core/Form/FormBuilder.php(323): Drupal\Core\Form\FormBuilder->processForm()
#19 /code/web/core/lib/Drupal/Core/Form/FormBuilder.php(222): Drupal\Core\Form\FormBuilder->buildForm()
#20 /code/web/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php(2257): Drupal\Core\Form\FormBuilder->getForm()
#21 [internal function]: Drupal\views\Plugin\views\display\DisplayPluginBase->elementPreRender()
#22 /code/web/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php(101): call_user_func_array()
#23 /code/web/core/lib/Drupal/Core/Render/Renderer.php(788): Drupal\Core\Render\Renderer->doTrustedCallback()
#24 /code/web/core/lib/Drupal/Core/Render/Renderer.php(374): Drupal\Core\Render\Renderer->doCallback()
#25 /code/web/core/lib/Drupal/Core/Render/Renderer.php(446): Drupal\Core\Render\Renderer->doRender()
#26 /code/web/core/lib/Drupal/Core/Render/Renderer.php(446): Drupal\Core\Render\Renderer->doRender()
#27 /code/web/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender()
#28 /code/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(242): Drupal\Core\Render\Renderer->render()
#29 /code/web/core/lib/Drupal/Core/Render/Renderer.php(580): Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}()
#30 /code/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(243): Drupal\Core\Render\Renderer->executeInRenderContext()
#31 /code/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(132): Drupal\Core\Render\MainContent\HtmlRenderer->prepare()
#32 /code/web/core/lib/Drupal/Core/EventSubscriber/MainContentViewSubscriber.php(90): Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse()
#33 [internal function]: Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray()
#34 /code/web/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(142): call_user_func()
#35 /code/vendor/symfony/http-kernel/HttpKernel.php(174): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch()
#36 /code/vendor/symfony/http-kernel/HttpKernel.php(81): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#37 /code/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle()
#38 /code/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
#39 /code/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
#40 /code/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
#41 /code/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
#42 /code/web/core/lib/Drupal/Core/DrupalKernel.php(718): Stack\StackedHttpKernel->handle()
#43 /code/web/index.php(19): Drupal\Core\DrupalKernel->handle()
#44 {main}

suggested patch

🇦🇺Australia gigimaor Narangba/Brisbane

Hi
I still have compatibility issues with Test Kernel on Drupal v9.5.7 and PHPUnit v9.6.6.
Suggesting this patch

🇦🇺Australia gigimaor Narangba/Brisbane

This one should work with version 1.2

🇦🇺Australia gigimaor Narangba/Brisbane

This one should work with version 1.2

🇦🇺Australia gigimaor Narangba/Brisbane

gigimaor created an issue.

Production build 0.71.5 2024