🇷🇸Serbia @g_miric

@joseph.olstad That is exactly what the new patch is doing. If there is a 404 page set in the "system.site" config and "use_system_404" is set to TRUE, it will take the get the page and make it static.

It doesn't make sense to take only the body field. In fact, the node that is set as the 404 page doesn't need to have a body field.

And if you really need to render only the body field then you should adjust the template for that node or to use the module setting "404 page body"

The new feature will be implemented within #3450805 ✨ Make the 404 page more configurable Needs work so I'm closing this issue.

@kensae Amazing. Thanks a lot!

The PR looks good. I requested some changes. Please ping me if you need help or if you have no time to implement them and I will do it.

Hi @joseph.olstad,

If this patch works for you, you could apply it at the moment, but globally this wouldn't work:
- It overrides the fast 404 message and that should be optional.
- It assumes that 404 config path starts with "node/" if it's a node, but it could be an alias too.
- It renders only the body field, and it should render the whole page (there could be no body field at all).
- It should support any type of url, e.g. it could be custom route

I will work on this feature as soon as I get some time.

Hi @joseph.olstad

Originally it was designed to override the default 404 page too, but this could be a feature request:

• There could be a checkbox (e.g. "Use content from 404 config page instead") in the config page below or above the 404 body field
• themed_fast_404 should get content of that page (it doesn't need to be node path)

I will work on that as soon as I'm available.

With that said, for some reason the sites/default/files/page-not-found-fr.html content that is generated is still using the settings value but the sites/default/files/page-not-found-en.html gets the expected node values even though I haven't changed any code from 1.0.5 .

The translation UI seems broken also.

I'm not able to reproduce any of these issues. Installed a new Drupal 10 site, added EN and FR languages, set FR as the default language, translated 404 config page, run cron, tested on EN and FR path and it looks good.

@jcninov If you run cron again it should take the value from configuration page for english language too.

It is designed to override/ignore the default 404 page and use the value from configuration page.
If you have an issue with translating 404 page body value this issue 📌 Support config translation Fixed fixes it.

g_miric → created an issue.

Works as advertised!

Should we change version to 10.2.x-dev or have another MR for it?

The latest patch worked for me too!

Works fine!
Thanks for the patch.

LGTM!

g_miric → created an issue.

hook_help() isn't a required method and generally I don't like it.
It adds an another place where we need to maintain module documentation (beside module page on drupal.org and readme file) and I find it unneeded.

You should check phpcs agains .md files.

Works as expected.

It is necessary. It fixes another issue 🐛 Stage file proxy attempts to fetch aggregated JS/CSS. Fixed

Any updates here? Did you guys tested it?

Target branch changed from 2.0.x to 2.1.x. Please review.

It isn't a core issue. I applied patch that resolves the core issue and the issue was still present.
Also, without this MR you are not able to excluded extensions. There is a config available for it, but not the code that will support it.

I will rebase in on 2.1.x branch.

Works as expected!

Stage file proxy is using StageFileProxySubscriber and it doesn't check config related to excluded extensions.
Here is a MR that fixes it.

Testing steps:

• Apply MR
• Set excluded extensions in the settings page (/admin/config/system/stage_file_proxy) - "js, css"
• Clear cache

g_miric → made their first commit to this issue’s fork.

g_miric → made their first commit to this issue’s fork.

Thanks roderik!
That solves my issue.

g_miric → created an issue.

+1 LGTM!

Looks good.

g_miric → created an issue.

+1 Works fine with D10

LGTM!