Hurrrrr
Here!
volkswagenchick → credited crasx → .
volkswagenchick → credited crasx → .
Attended!
Attended!
Good to meet everyone!
A performance profile visualization showing Drupal configuration dependency system execution time. The highlighted row, "php::array_multisort" consumes 25% of execution time with 130,893 executions, suggesting a potential optimization target. The most time-consuming function is ConfigManager::findConfigEntityDependencies at 66.88% of execution time with 105 executions.
volkswagenchick → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
JoiGarrett → credited crasx → .
volkswagenchick → credited crasx → .
Threw together a rough idea based on this convo - https://drupal.slack.com/archives/C01N7HQSSFN/p1691723963898109
AI helped with some content.
I plan on spending some time on this
volkswagenchick → credited crasx → .
volkswagenchick → credited crasx → .
Updating status, planning on circling back to this soon
Sorted!
Only slightly stressful :)
volkswagenchick → credited crasx → .
volkswagenchick → credited crasx → .
Such a great event and good turnout! Had a good time mentoring and meeting all the peoples
@brad.bulger it is not. The example.gitignore in Drupal root is used when a user downloads Drupal as a zip, the others are used during composer create-project. Do we maybe want to add a post composer create-project hook to remove example.gitignore?
Also linking #3294241 which removes the legacy project.
Bringing this back to life @ DC Pittsburgh. Learned way too much about the Drupal composer project templates. Some brilliant stuff for sure.
First, I wanted to share this nifty command I came across to make testing this easier (ie: create-project from a local directory)
composer create-project --prefer-dist drupal/recommended-project="@dev" 3082958-test-`date +%s` --repository '{"type": "path", "url": "drupal-3082958/composer/Template/RecommendedProject", "options": {"symlink": false}}'
source
I tested MR1627 using the above method with both legacy and recommended project and they worked well. I also think the approach of a .gitignore file with commented lines makes the most sense.
My initial hesitation with this was in the multiple gitignore files. But looking back at #3082958 it makes sense that we would have different gitignore files for each project template. The rules for those are pretty tightly coupled to the template they come from.
We have the example.gitignore file that gets scaffolded in from drupal/core, but that only has rules for sites/default/… I played with the idea of putting everything in example.gitignore and scaffolding it to project-root instead of web-root, but I think that will make the file overwhelming as noted in 3082958.
Now that we have a few years of composer deployments under our belts I think we can make these changes with a little more confidence. I +1 the approach in MR 1627. Using this approach has the added benefit of being compatible with projects like acquia/drupal-recommended-project who also provide a gitignore file via composer template (and not via scaffold)
In terms of remaining tasks I think we might want to consider opening another ticket to deal with the non-composer gitignore files. If we keep this ticket scoped to the composer templates we can probably move this along
Took a pass at this
hestenet → credited crasx → .
volkswagenchick → credited crasx → .
Tested this using the standard profile, with olivero:
- Visit homepage with caching fully enabled (ie: nothing checked) - warms cache
- Visit /admin/config/development/settings Check the do not cache markup checkbox / save
- Update a twig template used on the homepage (I updated `html.html.twig`)
- View homepage, confirm new change appears with no cache clear
- Visit /admin/config/development/settings Uncheck the do not cache markup checkbox / save
- View homepage, note old cached version before the change appears
I would expect the new version, is that an issue?
I worked with vleeayo1 on this for their first contribution as part of the Discover Drupal program! Based on convos above this should be RTBC. Code and tests make sense to me
Hanging out today!
volkswagenchick → credited crasx → .
volkswagenchick → credited crasx → .
volkswagenchick → credited crasx → .