paulsheldrake → made their first commit to this issue’s fork.
paulsheldrake → created an issue.
I have updated the project page with notes on switching
paulsheldrake → created an issue.
paulsheldrake → created an issue.
paulsheldrake → created an issue.
The token_filter module is not required
This is still an issue on the 2.7 release
thejimbirch → credited paulsheldrake → .
thejimbirch → credited paulsheldrake → .
Actually, looking into it a bit more, the file is uploaded, the URL is correct, and I can download the file. The folder for the individual submission is not getting created
It looks like this chunk of code in WebformManagedFileBase.php is not getting correctly firing
// Replace /_sid_/ token with the submission id.
if (strpos($destination_folder, '/_sid_')) {
$destination_folder = str_replace('/_sid_', '/' . $webform_submission->id(), $destination_folder);
$this->fileSystem->prepareDirectory($destination_folder, FileSystemInterface::CREATE_DIRECTORY | FileSystemInterface::MODIFY_PERMISSIONS);
}
paulsheldrake → created an issue.
thejimbirch → credited paulsheldrake → .
paulsheldrake → created an issue.
This should be ready to go.
paulsheldrake → changed the visibility of the branch 3417063-add-support-remote-video to hidden.
paulsheldrake → created an issue.
paulsheldrake → created an issue.
I had just checked it with 1.3.1 before I fixed my patch/MR for 1.3.3
The smallest image is 650px.
I have re-run the test with the following configuration for my media displays.
Those settings give me the following scores.
1.3.3 is an improvement compared to the previous versions and is more performant than LQP.
If you decide not to merge LQP, I'll keep the MR updated as we need it for our project.
Hi Sean
have been busy with project work recently so haven't had time to validate the data you were looking for.
What I have done is have 2 environments with the sole difference being whether LQP is enabled on each one. I then loaded the homepage through the webpagetest.org performance test.
There is a significant difference in the number of bytes and total page load speed between the two.
Without LQP
With LQP enabled
As you can see in the bytes transferred graph, we are sending more data in the HTML because of the encoded images but the total number of image files related bytes is significantly less.
Hope this helps you make a decision.
Cheers,
Paul
thejimbirch → credited paulsheldrake → .
What would be the best way to write a test for this @catch?
Have tested the updated patches
Have code reviewed the patch and tested and it works for me. Have seen massive performance gains on pages with any iframes
I believe this patch is ready to go now after some further on-site testing
paulsheldrake → created an issue.
The latest tag of drupal-rector is missing the D10 set https://github.com/palantirnet/drupal-rector/tree/0.15.1/src/Set. even though it is in the primary branch
I think there is the potential deal with this on the storybookJS side. Have made a feature request in the https://github.com/Lullabot/storybook-drupal-addon/issues/42 package
That's fair; it does at more technical complexity, which is more challenging to maintain.
In terms of metrics, however, I can provide some data. We're currently working on a new build and have a Lighthouse test run on our feature environments. We test the same URL 3 times and average the scores for each PR. Granted, we already had a pretty performant front end, but with this patch on the site, we get an average 3-point improvement for the performance metric when testing against the homepage.
Without LQP - Current site
With LQP - Feature environment
Here is the initial patch
Overview:
- Creates a new table and image style
- table to store the encoded image data. this is so we aren't stuck trying to encode things on the fly
- image style so we can control the LQP size. smaller images make for smaller encodings but come out blurrier.
- Updates the field formatted to have a checkbox to use LQP for individual displays
- Creates a new image style to generate the low-quality version of the images from
- Update the resizer to use `once` and intersection observer.
- once so we do attach observers multi times of ajax events happen
- intersection observer so we don't have to run updateImage() on all the images out of the gate and just load things as folks scroll
- Updates readme with some notes about LQP
paulsheldrake → created an issue.
paulsheldrake → created an issue.
Yeah, totally possible to example to other image types.
The reason I didn't here is:
- The project I'm on currently just needs it for SVGs :)
- Other file types can be quite large which then can cause memory issues, especially if there a lot of images to process.
That being said something to investigate more later if i get time
Usage example
<img src="{{ drupal_svg_encode('/themes/custom/theme_name/assets/icons/icon-rss.svg') }}" {{ attributes|without('src') }}>
Add some caching
Initial patch
paulsheldrake → created an issue.
Patch for getting exception message into the drupal log
paulsheldrake → created an issue.
paulsheldrake → created an issue.
For folks that are working in a local environment you can import your DB as the root user as a work around
MYSQL_CONNECTION_DETAILS="-h db -proot -u root default"
zcat $DBFILE | mysql $MYSQL_CONNECTION_DETAILSHaving thought about this a little bit I was thinking in the settings form, get a list of the enabled datasources and then generate the list of availbable bundle options from that.
When I poked around at it for 5 minutes I stumbled get getting the list of datasources before i gave up for another day