Create a Drupal 10.1 rule

Openend: https://github.com/palantirnet/drupal-rector/pull/252

@agentrickard can you add credits and mark fixed please?

The latest tag of drupal-rector is missing the D10 set https://github.com/palantirnet/drupal-rector/tree/0.15.1/src/Set. even though it is in the primary branch

Yeah its currently only released in main, we have not tagged a release. I think we will soon, but before that i want to have merged BC fixes into Rector.

✨ Add backward compatibility to Rector rules Needs review

hi there. adding myself to this thread so that i get notification when this is fixed. needless to say, checking for D10 compatibility is a big need for many of us right now ;-)

i had the same problem as @paulsheldrake (the D10 set missing) but at the time i was actually trying to test code for D9.5 compatibility, not D10, so I just removed the references to D10 from the rector.php configuration file, and used the more granular rule sets:

    $rectorConfig->sets([
    	Drupal9SetList::DRUPAL_90,
    	Drupal9SetList::DRUPAL_91,
    	Drupal9SetList::DRUPAL_92,
    	Drupal9SetList::DRUPAL_93,    
    ]);

now i get a different error:

[ERROR] You have requested a non-existent parameter "drupal_rector_notices_as_comments"

is this related to the current issue, or the backward compatibility fixes at https://www.drupal.org/project/rector/issues/3350886 ✨ Add backward compatibility to Rector rules Needs review ?

if not i will start a new issue

I am confused about how there could be all these upgrades to various modules, inserted into issues queues with subject "Automated Drupal 10 compatibility fixes", and mention as being as done by Drupal Rector... and yet there currently isn't a version of https://github.com/palantirnet/drupal-rector that works with D10? can anyone explain this?

This issue is mostly for checking for Drupal 11 compatibility. This would be deprecations that are added in the Drupal 10 lifecycle that need changing for Drupal 11.

This has been committed for the next release.

re: #11 that's great to hear!

that error i was getting (see #8)

[ERROR] You have requested a non-existent parameter "drupal_rector_notices_as_comments"

i already found the fix, by looking at the rector-config-template.php file provided by the upgrade_rector module.

rector.php should contain this line:

$parameters->set('drupal_rector_notices_as_comments', true);

i hope this can make it into the next release too :-)

Yes. It's going in the release notes.

re:#13 awesome! :-) thanks!

Automatically closed - issue fixed for 2 weeks with no activity.