Sevilla
Account created on 1 February 2011, almost 14 years ago
  • Drupal Analyst at AyesaΒ  …
#

Merge Requests

Recent comments

πŸ‡ͺπŸ‡ΈSpain jncruces Sevilla

The last patch in #180 was incorrect because has a creation of a new order but the variable is not set in the file "AddToCartForm.php".

The next patch solves the problem.

πŸ‡ͺπŸ‡ΈSpain jncruces Sevilla

Hi,

I created a new patch because the original return true if no route is present and the condition requires a route.

If no route it can't be validated.

Greetings.

πŸ‡ͺπŸ‡ΈSpain jncruces Sevilla

The following patch correct this behavior and the sidr will close normaly.

πŸ‡ͺπŸ‡ΈSpain jncruces Sevilla

The patch was created for the Drupal 9 version. The attached patch remove the info.yml changes to add only the changes that applies to the .module file.

πŸ‡ͺπŸ‡ΈSpain jncruces Sevilla

Confirmed the problem with D10.2.

The next patch solves the problem but I know that it needs more work because the schema of the configuration is incorrect. The patch works but needs more work.

πŸ‡ͺπŸ‡ΈSpain jncruces Sevilla

Hi,

Te url of the font must be a local path or a global domain, for example:

font-face {
font-family: APhont;
font-weight: bold;
src: url('https://www.yourdomain.com/.../aphont-bold.ttf') format("truetype");
}
span {
font-family: APhont, DejaVu Sans, sans-serif;
font-weight: bold;
}

The path can be a local path of the server, for example:

font-face {
font-family: APhont;
font-weight: bold;
src: url('/home/youruser/.../aphont-bold.ttf') format("truetype");
}
span {
font-family: APhont, DejaVu Sans, sans-serif;
font-weight: bold;
}

Try both.

Greetings.

πŸ‡ͺπŸ‡ΈSpain jncruces Sevilla

Corrected the autogenerated patch.

πŸ‡ͺπŸ‡ΈSpain jncruces Sevilla

Hi,

The branch 2.0.0 have not a 2.x develop branch and the module can't be patched from this.

The users must clone the 8.x-1.x branch (the develop branch) and use the patch attached here:

https://www.drupal.org/project/ckeditor_tabber/issues/3296776 πŸ“Œ Automated Drupal 10 compatibility fixes Needs review

πŸ‡ͺπŸ‡ΈSpain jncruces Sevilla

Attach the patch removing jquery/once and adding D10 compatibility.

The automated rector patch do not work.

πŸ‡ͺπŸ‡ΈSpain jncruces Sevilla

Hi,

Sorry for the time waiting my answer.

I don't know any limitation for the heading classes. Dompdf documentation and issues do not inform that: https://github.com/dompdf/dompdf

The images always is a problem, you can't provide a general solution i think. Normally you generate a content with pointing to a file and the module try to print that. Any suggestion will be accepted to a better solution.

Seems that the iframe are not supported by DomPDF: https://github.com/dompdf/dompdf/issues/1228

HTML can have infinite combinations and i don't know if DomPDF can apply all of them. In the module the html is "converted" minimally to get the PDF.

The library Dompdf has some limitations and the site builders should take these into account.

I do apologise of that last point was a silly questions, I'm not a heavy code developer; just a humble site-builder by trade.

Nothing to worry about. Any question to raise will always be welcome.

πŸ‡ͺπŸ‡ΈSpain jncruces Sevilla

Thanks the patch has been applied.

πŸ‡ͺπŸ‡ΈSpain jncruces Sevilla

The apply has made manually previously the patch has arrived.

Production build 0.71.5 2024