Contrib.social

Problem with hidden attr

Open on Drupal.org →
Created on 4 July 2024, 11 months ago

Problem/Motivation

When you place the trigger button to open/close the sidr region the open works but the hidden attribute assigned to the element make the transition events not work.

Steps to reproduce

1. Install the module and follow the installation steps.
2. Click on the trigger button.
3. The menu will show without transition.
4. Click the trigger button.
5. The menu do not become hidden, the transition never ends because it never started.

Proposed resolution

Change the attribute hidden to aria-hidden (rollback) and prevent focus with tabindex attribute.

Remaining tasks

Make a patch to correct this behavior.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report
Status

Active

Version

5.0

Component

Code

Created by

🇪🇸Spain jncruces Sevilla

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @jncruces
  • Comment 11 months ago →
    🇪🇸Spain jncruces Sevilla

    The following patch correct this behavior and the sidr will close normaly.

  • Status changed to Needs review 11 months ago
  • Comment 11 months ago →
    🇪🇸Spain jncruces Sevilla
  • Comment 9 months ago →
    🇨🇦Canada franckylfs Montreal

    I confirm that it works well with the patch from comment #2. Thanks!
    Otherwise, the menu does not close when you click on the button, the white background is not displayed when opening and the menu does not scroll automatically when you open a submenu.

  • Comment 4 months ago →
    🇨🇦Canada jigarius Montréal

    I've seen this issue, but I haven't had the time to look into it. I will check it out soon and get back to you.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024