🇦🇺Australia @akoepke

Have applied the patch from #73 in 10.3.10 and it has resolved this issue for us.

I noticed this after enabling the IP Login → module which uses Entity Type Manager in a middleware service: 🐛 Exceptions caused by middleware service using the entity_type.manager Active

akoepke → created an issue.

I have changed the field to ip_login_data and updated the database update hooks and SQL in the controller. I also added another database update to remove the ip_login field.

I was testing the upgrade path from the current 4.0.0-alpha2, is this the same version you were testing? I just did a clean install of the current release and then replaced it with this code and the upgrade went through without any issues.

I have incorporated this into another merge request

https://www.drupal.org/project/ip_login/issues/3194008 ✨ Allow multiple ip ranges per user Needs work

Can a maintainer please review this merge request and push out a new release of the module.

At the moment, upgrading a site from D7 to D10 while maintaining the IP login functionality isn't really possible.

akoepke → made their first commit to this issue’s fork.

akoepke → made their first commit to this issue’s fork.

You can configure this to support different entities and entity types. As these custom entities?

I haven't tried it with the Book module but see no reason why it wouldn't work as expected.

This is a use-case I had not considered or tested for. Webforms are a very different entity to standard content.

This module is designed to work on Content entities and expects them to have Entity View Displays. Supporting something like Webform would require a lot of changes specific for webform and may be better off implemented as a specific module.

Layout builder uses hook_entity_view_alter to add content to the page. As per the documentation, it forces itself to be the last hook called.

This is something that will require some further research as to how I can then modify the content it has added to the page.

I think it would make sense to have this added, it would be a configurable option.

To add this, I will need to implement hook_page_attachments for adding the structured data.

As the paywall operates on a per-field basis, the main challenge I can see is adding the wrapper classes.

It will most likely be a few weeks until I am able to get onto this but I will put it on the list of improvements for the next release.

As always, patches and contributions are also welcome.

Thanks for the feedback. I had forgotten about that documentation and it is for an older release of the module.

Can you please refer to the Readme.md file in the module's folder which has the most up-to-date instructions.

Thank you all for your contributions, sorry it has taken me a while to get onto this.

I have accepted the patch so these are now in the dev version of the module. I am planning to make some further improvements soon so will wait until those changes are ready before rolling out a new release.

akoepke → created an issue.

Thanks for the contribution.

I have had a look into this issue. The private URL should have a token at the end similar to s-3M4TCI8FWDC

This forms part of the path and the private track will load correctly if this is included.