leandro713 → created an issue.
Understood @Carol :-)
i still can't figure out why is this checked by default
anyway, thanks for your time and response, @Carol
leandro713 → created an issue.
leandro713 → created an issue.
@dtmajon:
no, sorry
we've ve taken another approach to solve the problem.
impossible to continue with this module with the current bug :-S
having the same issue :-(
I am having this problem too on a fresh new installation of Drupal 10, the error prevents the rendering of the new user creation form. It only appears there.
the error complains about the config form renderizing:
Drupal\Core\Render\Element\Checkboxes::valueCallback(Array, false, Object(Drupal\Core\Form\FormState))\n#1 /var/www/html/web/core/lib/Drupal/Core/Form/FormBuilder.php
Ah, yes, sorry @apaderno
I didnt understand how this works.
So ok, fixed
i reopen this issue because i dont see granted the security badge on the module's webpage → https://www.drupal.org/project/seo_keyword_links →
Yes, Álvaro. Finally, I managed to include the module settings in the tests. Thank you for your good advice.
However, I am currently experiencing problems with my local PHPUnit installation, so I cannot check the tests at the moment.
Anyway, I don't think this issue is urgent. I'm going to leave the module without tests for now because it works quite well for me.
Once I have a bigger user base, I can always add the tests, right?
@Rajan done; info.yml changed
branch 8.x-1.x is already ready to be reviewed again
@Rajan, thank you for reviewing the code formatting. I greatly appreciate the time you have dedicated to this.
I have corrected the code formatting by running PHPCS on all my files.
The 8.x-1.x branch is now ready for review.
I am investigating how to pass the configuration to the module within the test. If I succeed, I will upload the tests again.
As requested by @alvar0hurtad0, I have removed the tests.
However, this implies that without initial values in the configuration, it is impossible for me to test anything (configuration values would have to be provided to the test), making it impossible to write tests without specifying a lot of configuration, values in the node, etc.
It's quite messy and complicated :-(
Alvaro, first and foremost, I would like to express my utmost gratitude for your excellent review and the time you have dedicated to it. Secondly, having taken note of your observations, I have already made some changes in order to ensure a better verdict with regards to the security review.
Personally, I strongly believed that leaving a real example in the configuration was better for the user; however, I have deleted it following your recomendations.
Additionally, I have left the old Simpletest test available for Drupal 8 users and added another one for those who use Drupal 9.
Please don't forget to review the 8.x-1.x branch.
First of all, thank you very much for the excellent review and for the time you have dedicated to it, Alberto.
I have already corrected the issues you brought to my attention.
The 8.x-1.x branch is now ready to be reviewed again.
weird, i must have another PHPCS version, because i dont see those errors :-(
anyway i fixed all the errors i found
this is ready to review again
leandro713 → created an issue.
at the actual moment, i'm willing to maintain this project
merged!!
i attach a working patch for 8.x-9.x
leandro713 → created an issue.