Test that all form elements have a title for accessibility

I've updated this to an MR. I had to handle the removal of Book.

I also changed the deprecation removal notice to 11.x I'm not sure if that is correct.

Hiding all patches.

Ok this still needs work there are a lot of test failures.

I found that some errors are due to:

• A mismatch between the expected message and the actual message used inFormBuilder::doBuildForm.
• The deprecation of @expectedDeprecation annotations.

I'm updating the MR for these.

There are some uses of #label in the Content Translation and Language modules. Removing it (comments #197 & #202) caused several Exception: Warning: Undefined array key "#label" errors in tests.

Another error is caused by the missing #title for the test element in WeightTest.php.

I'll push an update that resolves these.

Question about the new validation code:

The code checks for the aria-labelledby attribute but not the aria-label attribute.

Was aria-label intentionally omitted? It's a valid method (though not preferred) of providing an accessible name, and it looks like core uses it for fields.

I'm also working on other test failures.

It looks like the original plan was to check for non-empty #title properties, but the MR only checked with isset().

Empty text doesn't provide an accessible name, so I changed the check to fully disallow empty #title properties. This caused a lot of new errors. Some of them are from 🐛 Content: Publishing status (grouped) is missing labels for inputs Active . I think the others are from the Views exposed filter forms themselves.

I also added aria-label to the conditions.