The PHPdoc for stream_seek() says:
/**
* Support for fseek().
*
* @param $offset
* The byte offset to got to.
* @param $whence
* SEEK_SET, SEEK_CUR, or SEEK_END.
*
* @return
* TRUE on success.
*
* @see http://php.net/manual/en/streamwrapper.stream-seek.php
*/
and the current implementation of stream_seek() returns the result of a fseek() call, which is documented as having a different return value on http://www.php.net/manual/en/function.fseek.php:
fseek()
Return Values:
Upon success, returns 0; otherwise, returns -1. Note that seeking past EOF is not considered an error.
So, for success, stream_seek() should return TRUE but fseek() returns 0.
The bug is noticeable when the image API calls getimagesize() for a .jpg image that has some EXIF metadata that it has to skip over (using fseek())
Fixed
11.0 🔥
file system
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
After being applied to the 8.x branch, it should be considered for backport to the 7.x branch. Note: This tag should generally remain even after the backport has been written, approved, and committed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This was fixed in 9.1.x. It was marked needs work for a backport to D7 however that is no longer supported. Marking fixed.
@kim.pepper, thanks for finding this.
The commit was actually made to Drupal 7. Changing version and adding credit for that work.
Author: Dries Buytaert <dries@buytaert.net>
Date: Sat Jul 10 01:51:02 2010 +0000
- Patch #844676 by chx, asimmonds: stream wrappers stream_seek() return is invalid.