The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- @voleger opened merge request.
- Status changed to Needs review
almost 2 years ago 9:00am 1 February 2023 - 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
I think that run-tests.sh is the old way of working because we were not using phpunit? Are we keeping this supported,
renaming this at this point in time doesn't feel needed/useful. - Status changed to Needs work
almost 2 years ago 9:33am 1 February 2023 - 🇺🇸United States mile23 Seattle, WA
Re: #76
We use run-tests.sh in the CI right now, and it would be great if it were more maintainable.
IIRC the reason it's got the .sh extension is that PHP won't discover the file, and so that htaccess type configuration can exclude it more easily. So it's a security through obscurity type scenario.
Changing the file name also means changing the CI system, and while it doesn't seem like we'd need to alter too much, we'd end up with different file names for different versions of core. A CI system maintainer could speak to whether that effort would be worth it, and what the future plans are for switching to a different test runner potentially.
In my ideal world this script would have been refactored into a symphony console based app, and thus much more maintainable and less ambiguous when it comes to file names. #2624926: Refactor run-tests.sh for Console component. → But I fear that ship has sailed as well, because we have always been 'just about to' switch over to something else.
