- First commit to issue fork.
- πΊπΈUnited States akalata
akalata β changed the visibility of the branch 601776 to hidden.
- πΊπΈUnited States akalata
This got so close, but stalled at the finish line. I'm still getting used to gitlab but will hopefully have #134 available as an MR soon.
- πΈπ°Slovakia poker10
Thanks for creating an MR for D7. It looks like a clean backport of the D8+ fixes.
I am a bit concerned about changing the markup on the form for logged in users from "textfield" to "item" - for BC reasons (sites can have custom styling which can potentially break, ...). Yes, it is the cleanest way how to fix this in D7, but maybe we should consider something with lesser impact - for example to rewrite the email and name in the
contact_personal_form_submit
? According to the backport policy for D7 ( https://www.drupal.org/about/core/policies/core-change-policies/what-pat... β ), changes like these are allowed only if the issue is Critical.(not creating a separe D7 issue just yet, in case we decide to commit it in this form - otherwise we should create a separate issue as per current backport policy)