Stop using post as a noun

This may be outdated and needs a check to see if there are still problems in D11 code. Please scan the code for uses of "post" as a noun, but ignore test fixtures.

Then spin off child issues by sub-system to keep the patches/MRs reasonably-sized.

From @andypost at https://drupal.slack.com/archives/C014QES6HSQ/p1696523077987389?thread_t...

In UI as noun it exists in forum...

core/modules/forum/src/ForumSettingsForm.php:54: 3 => $this->t('Posts - most active first'),
core/modules/forum/src/ForumSettingsForm.php:55: 4 => $this->t('Posts - least active first'),
core/modules/forum/templates/forum-list.html.twig:40:

Given 🌱 [Meta] Tasks to deprecate Forum Active , if forum module is the only remaining place this happens, I think we could close this as outdated, fourteen years after I opened it.

I searched core for POST and visually scanned the long list to confirm the usages were for the POST method. Then I searched for 'Post' and did the same scan. Finally searched for 'post' and there were many results. I gradually eliminated correct usages such as 'post update' etc. and eventually the results were small enough to change the grep to include the cases where post is used as a noun. This is the resulting command.

grep -rw post --exclude-dir=fixtures core/modules/book core/modules/forum core/modules/tracker core/includes/form.inc | grep -v 'post comments' | nl

The three modules, book, form and tracker, are approved for removal so we can eliminate those. That leaves form.inc which has an example using post as a noun.

 *   if ($success) {
 *     $message = \Drupal::translation()->formatPlural(count($results), 'One post processed.', '@count posts processed.');
 *   }
 *   else {

There is a change for that in the latest patch here. So we just need a new MR with that one change.

I have updated the IS and added some, but not all, credit.

After reading the relevant code, "items" makes sense in context and !4956 looks good.

Thanks, @sourabhjain.

Saving credit

Nice to close a 15 year old issue!

Committed to 10.2.x and 11.x Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.