- Issue created by @cybertrail
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, enable GitLab CI for the project, and fix what reported from the phpcs job. This help to fix most of what reviewers would report.
- For the time this application is open, only your commits are allowed. No other people, including other maintainers/co-maintainers can make commits.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application.
- Nobody else will get the permission to opt projects into security advisory policy. If there are other maintainers/co-maintainers who will to get that permission, they need to apply with a different module.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application. The configuration used for these tools needs to be the same configuration used by GitLab CI, stored in the GitLab Templates repository.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
- 🇮🇹Italy apaderno Brescia, 🇮🇹
I do not have time for a complete review, but I can report the following point.
src/Form/RncSettingsForm.php
$form['rnc_link'] = [ '#type' => 'markup', '#markup' => 'Link to send to participants:<br />' . $absolute_url, '#weight' => 100, ];Strings shown in the user interface must be translatable.
- 🇮🇳India vishal.kadam Mumbai
1. FILE: README.txt
The README file is missing the required sections → - Requirements, Installation, and Configuration.
2. FILE: rnc.module
File is empty and can be removed.
3. FILE: rnc.css
Twig code needs to be correctly indented. Drupal uses two spaces for indentation, not four spaces or tabs.
4. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml random_name_chooser/ FILE: /home/vishalkadam/DRUPAL-CONTRIBUTE/random_name_chooser/rnc.install ----------------------------------------------------------------------------- FOUND 9 ERRORS AND 2 WARNINGS AFFECTING 8 LINES ----------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 136 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 192 | ERROR | [ ] The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines 195 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 200 | ERROR | [ ] The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines 202 | ERROR | [x] Newline required after opening brace 202 | ERROR | [x] Closing brace must be on a line by itself 211 | ERROR | [x] Newline required after opening brace 211 | ERROR | [x] Closing brace must be on a line by itself 217 | ERROR | [x] Newline required after opening brace 217 | ERROR | [x] Closing brace must be on a line by itself ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------- FILE: /home/vishalkadam/DRUPAL-CONTRIBUTE/random_name_chooser/rnc.module ----------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------- FILE: /home/vishalkadam/DRUPAL-CONTRIBUTE/random_name_chooser/README.txt ------------------------------------------------------------------------ FOUND 1 ERROR AND 8 WARNINGS AFFECTING 8 LINES ------------------------------------------------------------------------ 4 | WARNING | [ ] Line exceeds 80 characters; contains 165 characters 9 | WARNING | [ ] Line exceeds 80 characters; contains 256 characters 13 | WARNING | [ ] Line exceeds 80 characters; contains 124 characters 15 | WARNING | [ ] Line exceeds 80 characters; contains 230 characters 17 | WARNING | [ ] Line exceeds 80 characters; contains 277 characters 19 | WARNING | [ ] Line exceeds 80 characters; contains 137 characters 21 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters 23 | WARNING | [ ] Line exceeds 80 characters; contains 165 characters 23 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------ FILE: /home/vishalkadam/DRUPAL-CONTRIBUTE/random_name_chooser/src/Form/RncSettingsForm.php ----------------------------------------------------------------------------- FOUND 10 ERRORS AND 2 WARNINGS AFFECTING 10 LINES ----------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Connection. 10 | WARNING | [x] Unused use statement 12 | WARNING | [x] Unused use statement 19 | ERROR | [ ] Missing short description in doc comment 24 | ERROR | [ ] Missing short description in doc comment 29 | ERROR | [x] Missing function doc comment 34 | ERROR | [x] Missing function doc comment 65 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 65 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1 66 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 66 | ERROR | [x] Whitespace found at end of line ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------- FILE: /home/vishalkadam/DRUPAL-CONTRIBUTE/random_name_chooser/src/Form/RncSelectNameForm.php ----------------------------------------------------------------------------- FOUND 31 ERRORS AND 7 WARNINGS AFFECTING 21 LINES ----------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Connection. 15 | ERROR | [ ] Missing member variable doc comment 17 | ERROR | [x] Missing function doc comment 21 | ERROR | [x] Missing function doc comment 37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 38 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 38 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 45 | ERROR | [x] Whitespace found at end of line 61 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 61 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1 61 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 109 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 109 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1 113 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 129 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 129 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1 131 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 164 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters 166 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters 166 | ERROR | [x] Inline comments must start with a capital letter 166 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 166 | ERROR | [x] Comments may not appear after statements 167 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 167 | ERROR | [x] Comments may not appear after statements 192 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 228 | ERROR | [x] Newline required after opening brace 228 | ERROR | [x] There should be no white space after an opening "{" 228 | ERROR | [x] Each PHP statement must be on a line by itself 228 | ERROR | [x] There should be no white space before a closing "}" 228 | ERROR | [x] Closing brace must be on a line by itself 231 | ERROR | [x] Newline required after opening brace 231 | ERROR | [x] There should be no white space after an opening "{" 231 | ERROR | [x] Each PHP statement must be on a line by itself 231 | ERROR | [x] There should be no white space before a closing "}" 231 | ERROR | [x] Closing brace must be on a line by itself ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 30 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------- FILE: /home/vishalkadam/DRUPAL-CONTRIBUTE/random_name_chooser/src/Form/RncDeleteNameForm.php ----------------------------------------------------------------------------- FOUND 19 ERRORS AFFECTING 12 LINES ----------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Connection. 24 | ERROR | [ ] Missing member variable doc comment 33 | ERROR | [x] Missing function doc comment 38 | ERROR | [x] Missing function doc comment 78 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 78 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 1 83 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 83 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 2 84 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 84 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4 85 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 85 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4 86 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 86 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found 2 87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6 88 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 88 | ERROR | [x] Whitespace found at end of line ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 18 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------- FILE: /home/vishalkadam/DRUPAL-CONTRIBUTE/random_name_chooser/src/Form/RncAddNameForm.php ----------------------------------------------------------------------------- FOUND 48 ERRORS AND 1 WARNING AFFECTING 26 LINES ----------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Connection. 18 | ERROR | [ ] Missing member variable doc comment 19 | ERROR | [ ] Missing member variable doc comment 20 | ERROR | [ ] Missing member variable doc comment 22 | ERROR | [x] Missing function doc comment 28 | ERROR | [x] Missing function doc comment 36 | ERROR | [x] Missing function doc comment 40 | ERROR | [x] Missing function doc comment 48 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 48 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3 48 | ERROR | [x] Object operator not indented correctly; expected 6 spaces but found 3 49 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 49 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3 50 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 50 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3 51 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 51 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3 58 | ERROR | [x] Array indentation error, expected 8 spaces but found 10 59 | ERROR | [x] Array indentation error, expected 8 spaces but found 10 83 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 83 | ERROR | [x] Line indented incorrectly; expected at least 4 spaces, found 3 83 | ERROR | [x] Array indentation error, expected 6 spaces but found 3 90 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 90 | ERROR | [x] Line indented incorrectly; expected at least 4 spaces, found 3 90 | ERROR | [x] Array indentation error, expected 6 spaces but found 3 97 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 97 | ERROR | [x] Line indented incorrectly; expected at least 6 spaces, found 2 97 | ERROR | [x] Array indentation error, expected 8 spaces but found 2 97 | WARNING | [ ] #description values usually have to run through t() for translation 135 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 135 | ERROR | [x] Array indentation error, expected 12 spaces but found 6 136 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 136 | ERROR | [x] Line indented incorrectly; expected at least 6 spaces, found 5 136 | ERROR | [x] Array indentation error, expected 8 spaces but found 5 137 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 137 | ERROR | [x] Line indented incorrectly; expected at least 6 spaces, found 5 137 | ERROR | [x] Array indentation error, expected 8 spaces but found 5 138 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 138 | ERROR | [x] Line indented incorrectly; expected at least 6 spaces, found 5 138 | ERROR | [x] Array indentation error, expected 8 spaces but found 5 139 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 139 | ERROR | [x] Line indented incorrectly; expected at least 6 spaces, found 5 139 | ERROR | [x] Array indentation error, expected 8 spaces but found 5 140 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 140 | ERROR | [x] Array closing indentation error, expected 6 spaces but found 3 141 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 141 | ERROR | [x] Array closing indentation error, expected 10 spaces but found 4 172 | ERROR | [x] Missing function doc comment ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 45 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------- FILE: /home/vishalkadam/DRUPAL-CONTRIBUTE/random_name_chooser/src/Form/RncAdminResultsForm.php ----------------------------------------------------------------------------- FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES ----------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 24 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 25 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 124 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 125 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------- FILE: /home/vishalkadam/DRUPAL-CONTRIBUTE/random_name_chooser/src/Service/RncMatcher.php ----------------------------------------------------------------------------- FOUND 9 ERRORS AND 1 WARNING AFFECTING 10 LINES ----------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 8 | ERROR | [x] Missing class doc comment 10 | ERROR | [ ] Missing member variable doc comment 11 | ERROR | [ ] Missing member variable doc comment 13 | ERROR | [x] Missing function doc comment 41 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 49 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null" 65 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 98 | ERROR | [x] Expected 1 blank line after function; 0 found 99 | ERROR | [x] The closing brace for the class must have an empty line before it ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------- FILE: /home/vishalkadam/DRUPAL-CONTRIBUTE/random_name_chooser/rnc.routing.yml ----------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------- 65 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -----------------------------------------------------------------------------NOTE:It is better to enable GitLab CI for the project, and fix what reported from the phpcs job.