- Issue created by @mondrake
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States smustgrave
Changes look good to me. Didn't see any abstract classes getting touched to class level legacy-covers.
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
nit: looks like some of the docblock indentations are incorrect. I assume this would be fixed automatically with phpcbf?
- 🇮🇹Italy mondrake 🇮🇹
#11 I couldn’t find any phpcs/bcf rule dealing with PHPDoc indentation, surprisingly. That also explains why the PHPCS ci job does not fail. But yeah, it looks like this is a good job for that tool.
FWIW, I could not find a coding standard on the same topic, either.
Looks like we need follow ups here, tagging.
