- Issue created by @balintbrews
- Merge request !7#3544433: Sort import statements in JS/TS files using Prettier → (Merged) created by Unnamed author
- 🇳🇱Netherlands balintbrews Amsterdam, NL
The first three commits contain the relevant changes. The last one is reformatting the files.
I also wrote documentation on how I configured the plugin, which is part of the first commit. - First commit to issue fork.
-
hooroomoo →
committed 04bc1403 on 1.x authored by
balintbrews →
Issue #3544433 by balintbrews: Sort import statements in JS/TS files...
-
hooroomoo →
committed 04bc1403 on 1.x authored by
balintbrews →
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This broke the
stylelintCI job. 😅See https://git.drupalcode.org/project/canvas/-/pipelines/588377 →
Error: Cannot find package '@ianvs/prettier-plugin-sort-imports' imported from /builds/project/canvas/web/modules/custom/canvas/noop.js - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
(Oh and let's ensure that the
stylelintCI job is triggered when necessary — I guess whenever**/package*.jsonchanges? I defer to @balintbrews 😄) - 🇳🇱Netherlands balintbrews Amsterdam, NL
Addressed both #8 and #9 in MR !29. I also made a CSS change earlier to verify that the job is now green when it runs.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Thanks for the super fast turn-around! 😮
Merged in upstream to be able to merge. 👍
-
wim leers →
committed a8f3fae3 on 1.x authored by
balintbrews →
[#3544433] feat: Follow-up: fix `stylelint` CI job By: balintbrews By:...
-
wim leers →
committed a8f3fae3 on 1.x authored by
balintbrews →
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.
