- Issue created by @danflanagan8
- First commit to issue fork.
- Merge request !708Issue #3543014: Make form_file_limit error message configurable β (Merged) created by jrockowitz
- πΊπΈUnited States jrockowitz Brooklyn, NY
I am in the middle of reviewing all outstanding tickets, and you got lucky because this should be an easy improvement.
Please review the MR.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
liam morland β made their first commit to this issueβs fork.
- πΊπΈUnited States danflanagan8 St. Louis, US
Lucky indeed! I'm glad I decided to go for a run before working on it myself. :)
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Tests are not passing.
- πΊπΈUnited States danflanagan8 St. Louis, US
I've applied the patch of the MR locally and it works great, with the exception of the global admin form, which should be an easy fix.
- The update hook runs and sets the new default value for default_form_file_limit_message
- The default message is used when I don't set form_file_limit_message
- The custom message is used when I set it
- The %quota token works
It's really great.
- πΊπΈUnited States danflanagan8 St. Louis, US
I went ahead and made all of my suggested changed. Hopefully that wasn't stepping on any toes.
The tests are passing now, but there's a merge conflict. D'oh! Leaving at NW to get that resolved.
- πΊπΈUnited States danflanagan8 St. Louis, US
Change of heart. I'm going to throw it into NR despite the conflict.
The conflict is in webform.install.update.inc, which has been updated twice in the last couple days. I suspect a conflict like this is most efficiently resolved very shortly prior to commit, probably by the maintainer.
- πΊπΈUnited States jrockowitz Brooklyn, NY
We need to address the feedback which I missed.
-
jrockowitz β
committed 9eb1fb52 on 6.3.x
[#3543014] feat: Make form_file_limit error message configurable By:...
-
jrockowitz β
committed 9eb1fb52 on 6.3.x
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.
-
jrockowitz β
committed 9eb1fb52 on 6.x
[#3543014] feat: Make form_file_limit error message configurable By:...
-
jrockowitz β
committed 9eb1fb52 on 6.x