- Issue created by @mglaman
- π©πͺGermany marcus_johansson
Makes total sense to me, we have added a lot of exceptions since we started.
I'll set this to 1.2.x, since I can't see any reasons that this would be a breaking change?
I think we should add a follow up issue as well after that, to write documentation about the exceptions and document when to extend the marker interface or use the exceptions as a third party module.
- First commit to issue fork.
- π©πͺGermany D34dMan Hamburg
@marcus_johansson,
Should the interface be named `AiExceptionInterface` ?
- πΊπΈUnited States mglaman WI, USA
I'll set this to 1.2.x, since I can't see any reasons that this would be a breaking change?
Yeah nothing should break. The interface isn't adding methods at all.
- π©πͺGermany marcus_johansson
@d34dman - It would need the suffix for the tests to pass, so if nothing else for that reason we should change the name.
- πΊπΈUnited States mglaman WI, USA
10 | WARNING | Interface names should always have the suffix "Interface" | | (Drupal.Classes.InterfaceName.InterfaceSuffix)
Didn't read phpcs fail, turns out coding standards dictated the answer.
- π©πͺGermany D34dMan Hamburg
Looks like tests are failing on changes un-related to this MR, so requesting a review.
-
marcus_johansson β
committed 03870836 on 1.2.x authored by
d34dman β
Resolve #3542498 "Provide an exception"
-
marcus_johansson β
committed 03870836 on 1.2.x authored by
d34dman β