- Issue created by @quietone
- First commit to issue fork.
- Merge request !13075Issue 3541507: Remove deprecated field_layout support from layout_builder.install → (Open) created by Unnamed author
- 🇮🇳India deepakkm
I think the test also needs to worked upon, hence moving in progress.
- 🇺🇸United States smustgrave
Still seems to be the same issue summary
- 🇺🇸United States dcam
The changes look OK to me with the exception of one thing. I left a suggestion on the MR.
- 🇺🇸United States dcam
I don't know the internals of Layout Builder well enough to understand what this install function does. So I'm not comfortable OKing the changes. But I did notice that the old code saved the display entity. The new code does not. That seems like an oversight. If the tests pass despite that, then it probably indicates a lack of test coverage.
- 🇮🇳India ajinkya45 Pune
The failing tests (
LayoutBuilderOptInTest
) are asserting that Layout Builder should not be enabled by default, but my patch enables it on all displays. Can we confirm whether the intent is to move to Layout Builder being always enabled by default, or should we only be enabling it when migrating from field_layout? - 🇺🇸United States smustgrave
Shouldn't the test and install be moved to field_layout. This seems to be losing test coverage and functionality moving to contrib