- Issue created by @joachim
- First commit to issue fork.
- Merge request !12941Issue #3539530: VersionHistoryController should document its soft expectations. → (Closed) created by neerajsingh
- 🇮🇳India neerajsingh IN 🇮🇳
Updated the documentation for VersionHistoryController.
- 🇬🇧United Kingdom joachim
Looks good, but I'm not sure the @see links to specific entities is right here.
- 🇮🇳India neerajsingh IN 🇮🇳
Yes true, with the @see links are entity-agnostic, rather we can have references to revision-related routes and interface
\Drupal\Core\Entity\Routing\RevisionHtmlRouteProvider
\Drupal\Core\Entity\RevisionableInterface - 🇳🇿New Zealand quietone
This is a nice improvement but I wonder why it is referring to annotations since attributes are now used.
- 🇬🇧United Kingdom joachim
Oh yes, good point!
While we're NW, spotted a nitpick.
- 🇺🇸United States nicxvan
I created code suggestions that can be applied directly in the MR interface.
- First commit to issue fork.
- 🇬🇧United Kingdom nexusnovaz
Will move this back to NR as i've made the changed. Thanks @nicxvan for those, I wasn't sure if it would do more than 1 commit, so i did it manually.
- 🇺🇸United States nicxvan
@nexusnovaz you can do them individually or in a batch, when there is more than one it asks you to add to a batch then there is an option to apply the full batch.
Doing it manually is ok as well.
-
quietone →
committed 48456423 on 11.2.x
Issue #3539530 by neerajsingh, joachim, nicxvan:...
-
quietone →
committed 48456423 on 11.2.x
-
quietone →
committed d0d79c13 on 11.x
Issue #3539530 by neerajsingh, joachim, nicxvan:...
-
quietone →
committed d0d79c13 on 11.x
- 🇬🇧United Kingdom joachim
Thanks! As a docs-only fix, can this be committed to the 10 branch too?
Automatically closed - issue fixed for 2 weeks with no activity.