ControllerResolver should use RouteObjectInterface::CONTROLLER_NAME instead of the _controller string

I'll take a look on this

does that looks like as it should ?

nicxvan → changed the visibility of the branch 3538669-controllerresolver-should-use to hidden.

nicxvan → changed the visibility of the branch 3538669-controllerresolver-should-use to active.

I think it's supposed to be on the branch that was created, not the 11.x.

I'm not sure if that actually causes a problem or not though.

I think we should expand the scope to change this everywhere _controller is used.

The constant is currently used in these places:

\Drupal\jsonapi\Revisions\ResourceVersionRouteEnhancer::enhance
\Drupal\jsonapi\Routing\Routes
\Drupal\Tests\jsonapi\Unit\Routing\RoutesTest

Should we update in the following places too:

\Drupal\Core\Controller\ControllerResolver
\Drupal\Core\Controller\ControllerResolverInterface (docs)
\Drupal\Core\Entity\Enhancer\EntityRouteEnhancer
\Drupal\Core\Entity\EntityResolverManager
\Drupal\Core\Entity\Routing\DefaultHtmlRouteProvider
\Drupal\Core\Routing\Enhancer\FormRouteEnhancer
... probably some other places too

Let's take care of all of them and move to the branch the issue created.

Raised PR with fixes in the following files:

1. core/lib/Drupal/Core/Controller/ControllerResolverInterface.php
2. core/lib/Drupal/Core/Entity/Enhancer/EntityRouteEnhancer.php
3. core/lib/Drupal/Core/Entity/EntityResolverManager.php
4. core/lib/Drupal/Core/EventSubscriber/SpecialAttributesRouteSubscriber.php
5. core/lib/Drupal/Core/Routing/Enhancer/FormRouteEnhancer.php
6. core/tests/Drupal/Tests/Core/Controller/ControllerResolverTest.php