"Abc Xyz+" does not get replaced

vinodhini.e → made their first commit to this issue’s fork.

Ok this should do the trick! The problem was, that we use a word boundary at the end of the regex pattern ("/b"). Since "+" isn't considered a word character, the pattern can not match Abc Xyz+.

Drupal probably also allows entities to be named "+Abc Xyz" as well? I guess that will also fail because of the leading "/b". I will provide a test and a fix tommorow.

Thanks @grevil. We have to be careful then, because maybe the change will lead to issues where partial words are replaced, which might be undeserved. Maybe we'll need a setting, if we don''t find a good general solution. Thanks for finding out the reason so far!

Maybe we should first add an issue to add tests for not breaking partial words. After merging that and updating the fork, I guess they will fail expectedly.

Now that 📌 Add tests to check, that words partially containing an entity name won't get glossified Active is fixed, let's see if the tests still succeed.

Nice the test fails now!

Nice! So let's add the 4-options select option for "Partial word match":

• Only match whole words (default)
• Match partially at end of words
• Match partially at beginning of words
• Match partially anywhere

Nice! So let's add the 4-options select option for "Partial word match":

Only match whole words (default)
Match partially at end of words
Match partially at beginning of words
Match partially anywhere

I don't think, that is related to this issue, but we can create a follow-up issue for that in the future.

The current approach should be the option we have to fix this issue.

It will have problems with terms like " test ", "test." or "test," but I don't think it is even possible to save drupal entities having a label with a trailing whitespace? And using "." or "," inside the label is also super uncommon and would have let to a problem before.

Regarding the many tests we have, this fix is fairly "save". I'll merge it.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.