- Issue created by @Anybody
- ๐ฎ๐ณIndia vinodhini.e chennai
vinodhini.e โ made their first commit to this issueโs fork.
- First commit to issue fork.
- @grevil opened merge request.
- ๐ฉ๐ชGermany Grevil
Ok this should do the trick! The problem was, that we use a word boundary at the end of the regex pattern ("/b"). Since "+" isn't considered a word character, the pattern can not match Abc Xyz+.
Drupal probably also allows entities to be named "+Abc Xyz" as well? I guess that will also fail because of the leading "/b". I will provide a test and a fix tommorow.
- ๐ฉ๐ชGermany Anybody Porta Westfalica
Thanks @grevil. We have to be careful then, because maybe the change will lead to issues where partial words are replaced, which might be undeserved. Maybe we'll need a setting, if we don''t find a good general solution. Thanks for finding out the reason so far!
- ๐ฉ๐ชGermany Anybody Porta Westfalica
Maybe we should first add an issue to add tests for not breaking partial words. After merging that and updating the fork, I guess they will fail expectedly.
- ๐ฉ๐ชGermany Grevil
Now that ๐ Add tests to check, that words partially containing an entity name won't get glossified Active is fixed, let's see if the tests still succeed.
- ๐ฉ๐ชGermany Anybody Porta Westfalica
Nice! So let's add the 4-options select option for "Partial word match":
- Only match whole words (default)
- Match partially at end of words
- Match partially at beginning of words
- Match partially anywhere