- Issue created by @tarawij
- @tarawij opened merge request.
- ๐ฆ๐บAustralia tarawij
A merge request has been submitted to fix this issue:
[!92: Add migrate_plus as a required dependency](https://git.drupalcode.org/project/migrate_tools/-/merge_requests/92)This MR updates `migrate_tools.info.yml` to declare `migrate_plus` as a required dependency.
This resolves the runtime issue observed in both 6.1.0 and 6.1.1.
- heddn Nicaragua
Ideally we identify what made this hard dependency on migrate_plus in 6.1 and revert/rollback/fix that. Is that even possible?
- First commit to issue fork.
- @cb_govcms opened merge request.
This seems to have existed since Migrate Plus was made optional in v6.
Menu links are only added if Migrate Plus exists but the routes are defined regardless. And so the "Configure" link for Migrate Tools on the extend page links to '/admin/structure/migrate' which errors when Migrate Plus is not installed.
I have created an MR which adds the dependency to the routes and thus removes the Configure link if Migrate Plus is not present.
- heddn Nicaragua
Is there any way to add a simple functional test for this scenario? I'm sure there is. Let's add that so this doesn't surface again.
- ๐ณ๐ฎNicaragua jeremy1606
jeremy1606 โ changed the visibility of the branch 3536772-add-migrate-plus-dependency to hidden.
- ๐ณ๐ฎNicaragua jeremy1606
Iโve added a functional test to cover this scenario. The new test installs migrate_tools without migrate_plus, logs in with a user that has the โadminister migrationsโ permission, and attempts to access /admin/structure/migrate. The test ensures that the route does not trigger a fatal error (accepting 200/403/404 as valid outcomes). This should prevent regressions and confirm that the fix in !97 works as expected.
- ๐ช๐ธSpain selvira Seville, Spain ๐ช๐ธ, UTC+2 ๐ช๐บ
Hi I tested the latest changes and it worked.
Best, -
heddn โ
committed b2198226 on 6.0.x authored by
cb_govcms โ
Issue #3536772 by cb_govcms, jeremy1606, heddn: migrate_plus dependency...
-
heddn โ
committed b2198226 on 6.0.x authored by
cb_govcms โ