- Issue created by @mayur-sose
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Similar symptoms as π After an error itβs possible to get trapped in an unrecoverable error state Active !
- First commit to issue fork.
- Merge request !1394Draft: #3532618 unauthenticated gets dedicated handling β (Open) created by bnjmnm
- πΊπΈUnited States bnjmnm Ann Arbor, MI
bnjmnm β changed the visibility of the branch 3532618-after-session-times to hidden.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Neat approach. Can we get a kernel test added for the authentication checker?
- πΊπΈUnited States bnjmnm Ann Arbor, MI
Neat approach. Can we get a kernel test added for the authentication checker?
Yep,! There's a bunch of other tests that need updating too - I just didn't want to do all that refactoring until I got a +1 but now that I have one I'll hop on that.
- Assigned to bnjmnm
- Status changed to Needs work
3 days ago 12:08pm 26 August 2025 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Looking good! Missing some cacheability bits β provided pointers to prior art.
Two tests are failing:
- one thanks to the new
testAuthenticationRequiredPermission()
(π) β it identified one route definition that still needs to be updated - one which I suspect is due to a bug in the new access check: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
- one thanks to the new
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Would also be nice to get a GIF of this new UI functionality in action π
- πΊπΈUnited States bnjmnm Ann Arbor, MI
Failing test is just a flaky Playwright
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Reopened a thread, because I don't understand the answer: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
A mild concern about relying on https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/Authentication#... at https://git.drupalcode.org/project/experience_builder/-/merge_requests/1... β but I'm okay with merging as-is.
Just need to get clarity on that one thing π
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Ahhhhh!
public function testAssetLibrary(): void { // Delete the library created during install. $library = AssetLibrary::load(AssetLibrary::GLOBAL_ID); \assert($library instanceof AssetLibrary); $library->delete();
That is why! Reverting my revert, and merging π
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Manually tested, works well π
-
wim leers β
committed 2a9ff9e2 on 1.x authored by
bnjmnm β
Issue #3532618 by bnjmnm, wim leers, mayur-sose: After session times out...
-
wim leers β
committed 2a9ff9e2 on 1.x authored by
bnjmnm β
After renaming the cookie and reloading the page, I am getting the following session timeout error:
{ "errors": [ "You must be logged in to access this resource." ] }
Error 401: You must be logged in to access this resource.
And after clicking on the "Go to login" button, the page is correctly redirected to the login page. This behaviour is working as expected. Now, the page is not getting stuck on the error page.