After source session timeout, XB page stuck on the error message

Similar symptoms as 🐛 After an error it’s possible to get trapped in an unrecoverable error state Active !

bnjmnm → changed the visibility of the branch 3532618-after-session-times to hidden.

Neat approach. Can we get a kernel test added for the authentication checker?

Neat approach. Can we get a kernel test added for the authentication checker?

Yep,! There's a bunch of other tests that need updating too - I just didn't want to do all that refactoring until I got a +1 but now that I have one I'll hop on that.

Looking good! Missing some cacheability bits — provided pointers to prior art.

Two tests are failing:

1. one thanks to the new testAuthenticationRequiredPermission() (👍) — it identified one route definition that still needs to be updated
2. one which I suspect is due to a bug in the new access check: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...

Would also be nice to get a GIF of this new UI functionality in action 😇

Failing test is just a flaky Playwright

Reopened a thread, because I don't understand the answer: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...

A mild concern about relying on https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/Authentication#... at https://git.drupalcode.org/project/experience_builder/-/merge_requests/1... — but I'm okay with merging as-is.

Just need to get clarity on that one thing 😇

Ahhhhh!

  public function testAssetLibrary(): void {
    // Delete the library created during install.
    $library = AssetLibrary::load(AssetLibrary::GLOBAL_ID);
    \assert($library instanceof AssetLibrary);
    $library->delete();

That is why! Reverting my revert, and merging 👍

Manually tested, works well 👍

🎉

After renaming the cookie and reloading the page, I am getting the following session timeout error:

{
    "errors": [
        "You must be logged in to access this resource."
    ]
}

Error 401: You must be logged in to access this resource.

And after clicking on the "Go to login" button, the page is correctly redirected to the login page. This behaviour is working as expected. Now, the page is not getting stuck on the error page.

We need to adjust the errors that are displayed to user in this situation. This isn't really an unexpected error.. This is just the users session timing out?

Yeah, I was thinking that too — but this is such a massive improvement compared to where we were before that I didn't want to push back over this. 😅

+1 for landing the fix as it is but it would be great to plan for doing #24 🐛 After source session timeout, XB page stuck on the error message Active too.

Okay — but what do you expect that to look like? We were flying blind here: empty proposed solution in the issue summary, no designs.

So: the hard part is done — now we just need to tweak it to no longer have this less-than-great UX 😊