- Issue created by @narendraR
- First commit to issue fork.
- Merge request !664Issue #3529313: Add `getStructuredOutput()` method to... โ (Merged) created by Unnamed author
- ๐ฉ๐ชGermany marcus_johansson
@narendrar - I think this should be an extra interface that derives from ExecutableFunctionCallInterface - there are tool that neither have data structures to give back, where its not useful or where they are derived dynamically so its unclear what a data structure should be.
If we add a StructuredFunctionCallInterface, we could also add it in the plugin manager, so you can filter on functions that returns this.
We should also document some best practices what is expected to be returned here, since its an array which is very open for interpretation. WDYT?
- ๐ฎ๐ณIndia narendraR Jaipur, India
@marcus_johansson, I agree that adding getStructuredOutput() directly to
ExecutableFunctionCallInterface
may not be ideal since many tools donโt have structured data to return. Creating a new interface that extends ExecutableFunctionCallInterface and updating plugin manager is a better option. - ๐ฉ๐ชGermany marcus_johansson
Ok, added - since testing was missing for the plugin manager in general, I added some tests outside of the scope of this issue as well.
- ๐ฉ๐ชGermany marcus_johansson
Actually, we will need a setStructuredOutput as well, to return the tool to its previous state on loops - right now that happens on the string output, but for complex tools, that will not be enough I think?
- ๐ฉ๐ชGermany marcus_johansson
Ok, that is added now. Ready to review.
- ๐ฎ๐ณIndia narendraR Jaipur, India
Changes looks good to me. Both methods are useful addition.
- ๐ฉ๐ชGermany marcus_johansson
Swtiching to 1.2.x - its not breaking since its a new interface.
- ๐ฉ๐ชGermany marcus_johansson
Thank you for the review and thank you anjaliprasannan for the base work. Getting merged.
-
marcus_johansson โ
committed 0ca6fbaf on 1.2.x authored by
anjaliprasannan โ
Issue #3529313: Add `getStructuredOutput()` method to...
-
marcus_johansson โ
committed 0ca6fbaf on 1.2.x authored by
anjaliprasannan โ
-
marcus_johansson โ
committed 0ca6fbaf on 2.0.x authored by
anjaliprasannan โ
Issue #3529313: Add `getStructuredOutput()` method to...
-
marcus_johansson โ
committed 0ca6fbaf on 2.0.x authored by
anjaliprasannan โ
Automatically closed - issue fixed for 2 weeks with no activity.