- Issue created by @quietone
- 🇳🇿New Zealand quietone
Are there any other formatting changes to make here? Anything for consistency across the sections?
- 🇬🇧United Kingdom jonathan1055
Would you like this branch to temporarily build the actual documentation site, then we could check the built pages. I can add that here if it would be helpful.
- 🇳🇿New Zealand quietone
Yes, it would be helpful. And I copied your work from the other issue and the pages are deployed for testing.
- 🇳🇿New Zealand quietone
I went a bit all out on renaming files for simplicity and consistency.
- 🇬🇧United Kingdom jonathan1055
There could be a few conflicts here, so I suggest we get MR2 and MR4 merged first, then see where we are.
- 🇬🇧United Kingdom jonathan1055
I have aligned the pipeline changes with 'main' so we now run cspell and do not allow it to fail.
- 🇬🇧United Kingdom jonathan1055
The pipeline failed but it seems that some of the spelling errors are in files that have been renamed. I updated the issue fork (using the gitlab UI when browing the repository) but that has not solved it.
- 🇳🇿New Zealand quietone
@jonathan1055, apologies for the poor rebase I did. And thanks for the fixes.
- 🇬🇧United Kingdom jonathan1055
No problem. I used the MR suggestions, to make it easier to see what was original and which new changes needed to be reverted.
Point 1 in PHP -> Quotes does not seem to be rendered properly. I have not done an exhaustive review of all the pages, but just mentioning things as I spot them. But it may be good to get these renames committed soon(ish) so that we don't get rebase errors again if new issue branches are opened.
- 🇳🇿New Zealand quietone
This Data types section it not in sync with the d.o pages. This is one where I reverted the changed due to feedback in Slack and I didn't get back to properly review the situation. The discuss → tab for that page has more details. I'll make an effort to look into that today.
- 🇳🇿New Zealand quietone
The compared the text on d.o with the issue ✨ Adopt phpstan phpdoc types as canonical reference of allowed types Active and it is mostly correct text. There is one sentence still there that should not be. I have made that change on d.o and to the MR.
- 🇬🇧United Kingdom jonathan1055
I have added links to the documentation sites, as it can be confusing having two outputs here. This is only due to the temporary override in the .gitlab-ci.yml.
I'm going to see if we can find a better way to do this in Gitlab Templates generally, so that there is only one temporary documentation site, and the "live" site would only get updated on merging into the main repo.
- 🇳🇿New Zealand quietone
Finally back here to finish this. There were eslint errors on the mkdocs.yml file, which don't make sense as that file is formatted correctly. And since there are no .js files here I have changed this to not run eslint.
If there are no objections then the only thing to do is to remove the temporary code in .gitlab-ci.yml and commit this.