- Issue created by @jonathan1055
- Status changed to Needs review
25 days ago 12:19pm 7 June 2025 - 🇬🇧United Kingdom jonathan1055
I have created a new branch called
d10-docpages
and pushed an initial commit. This branch does not have any.module
or.info.yml
orcomposer.json
files. However it does have amkdocs.yml
anddocs/index.md
.We can work on the changes neede to test the 'pages' job in due course. But the immediate reason for adding this branch is to allow testing of ✨ PHPCS is run even when it cannot check any files Active
- 🇬🇧United Kingdom jonathan1055
Here's the new repo
https://git.drupalcode.org/project/gitlab_templates_downstream/-/tree/d1...Although I have just noticed that we had suggested using the 'main' branch for documentation. That may be a better idea, rather than have a new branch. I should have read the issue summary before working on it! I came from the other issue and just did it.
- 🇬🇧United Kingdom jonathan1055
I've opened MR18 to use the 'main' branch. If this works, then when committed we can see if we can delete the new 'd10-docpages' branch. But leave it there until we know that the 'main' branch works OK for this purpose.
- 🇬🇧United Kingdom jonathan1055
This is now ready for review. The documentation test build is https://gitlab-templates-downstream-1d35fd.pages.drupalcode.org/
I added the README.md as a page, by copying the file into /docs in the before_script, but it gets ignored as the log says
WARNING - Excluding 'README.md' from the site because it conflicts with 'index.md'
. So I renamed it slightly when copying and that works fine.I have also added a logo.png, which is a copy of the Gitlab Template logo, but with a spray-can effect using the Drupal official light blue, just to make it different.
- 🇪🇸Spain fjgarlin
The MR looks good. RTBC.
I think there is a setting in the Gitlab repo admin area to fix the URL, if that's what we want here.
It's underDeploy > Pages > Set unique domain name
(it might be checked by default and we just need to uncheck it). - 🇬🇧United Kingdom jonathan1055
... setting in the Gitlab repo admin area to fix the URL
By "fix" do you mean removing the extra
-1d35fd
in https://gitlab-templates-downstream-1d35fd.pages.drupalcode.org/
I was wondering what that string was. It's not related to a commit, as it is consitent over all commits in the MR.I have just unticked that setting and will run the pipeline again to see. For reference, attached are before arnd after settings.
- 🇬🇧United Kingdom jonathan1055
Unticking that box caused the url to change from
https://gitlab-templates-downstream-1d35fd.pages.drupalcode.org/
to
https://project.pages.drupalcode.org/gitlab_templates_downstream/ - 🇪🇸Spain fjgarlin
Yeah, GitLab generates random unique domain names, but they are not predictable. It's nicer as a path from
projects.pages.drupalcode.org
in my opinion. -
jonathan1055 →
committed c147104c on main
Issue #3515276: Add documentation .md files to test the pages job
-
jonathan1055 →
committed c147104c on main
- 🇬🇧United Kingdom jonathan1055
I have just realised that the change to the pages job
rules:
was included in the merge.We may want to look at that again, and change it. But it also may depend on if we c hange anything in 📌 Only rebuild documentation pages when source has changed Active which is another issue on my radar that I want to work on.
- 🇪🇸Spain fjgarlin
I thought that it was intentional in this MR, that's why I didn't mention anything. Agree, we can review that code in the related issue.
- 🇬🇧United Kingdom jonathan1055
Adding that issue so we can get back to here when working on it.
- Merge request !23#3515276 Add before_script_action to fail pages job → (Merged) created by jonathan1055
- 🇬🇧United Kingdom jonathan1055
MR23 is ready for review. It adds a
BEFORE_SCRIPT_ACTIONS
value of "pages-fail". The logs show the expected warnings, but I have not set the--strict
option yet. That will be done when I use this MR in the changes for MR374 on ✨ Use markdown-link-check to verify .md links Active -
jonathan1055 →
committed 359d17c1 on main
Issue #3515276 by jonathan1055, fjgarlin: Add before_script_actions to...
-
jonathan1055 →
committed 359d17c1 on main