- Issue created by @joseph.olstad
- 🇮🇳India amitrawat056
The Text Field Formatter module (version 2.0.1) is fully compatible with Drupal 11. It was installed using Composer with the following command: composer require 'drupal/text_field_formatter:^2.0'
There are no deprecation issues or errors, and the module works as expected. - First commit to issue fork.
- 🇨🇦Canada joseph.olstad
@jannakha have you tested the MR 7 fix with D11? I haven't yet tested.
- 🇦🇺Australia jannakha Brisbane!
@joseph.olstad
yes, I tested it on D11 (comment #2 is correct too)
MR7 doesn't have any functional changes, it contains PHPCS fix (code formatting) and array manipulation.
the module now expects Drupal 10.2+ or 11 (no more 8+) (since other Drupal versions are not supported it makes sense) - 🇨🇦Canada joseph.olstad
Ok Great, look forward seeing a tagged release with this , I believe one of my projects needs this upgrade.
- 🇦🇺Australia jannakha Brisbane!
you might want to ask to be a maintainer of the module - it's always beneficial to have multiple maintainers and this project hasn't been released for 2 years
- 🇹🇷Turkey alexander.levitsky Antalya
Hi @vladimiraus,
Thank you for your patch.
Could you please clean up your pull request by removing the changes that are not related to the PHPCS fixes, such as the addition of the GitLab CI file and the updates to the README? Once that's done, we’ll be able to proceed with merging your PR.
Best regards,
Alex - 🇨🇦Canada joseph.olstad
@alexander.levitsky, the addition of the .gitlab-ci.yml file is very useful, why would you want to remove it?
There's many reasons for it, not the least of which is the deprecation test coverage handled by phpstan. This helps ensure upwards compatibility going forward.
- 🇦🇺Australia VladimirAus Brisbane, Australia
Yes, +1 for merging.
This one is good to go.@alexander.levitsky do you need a help with release?