- Issue created by @xmacinfo
-
fjgarlin →
committed df62b98d on 2.x
#3526187: Fix skip to link.
-
fjgarlin →
committed df62b98d on 2.x
- 🇪🇸Spain fjgarlin
Thanks for reporting this @xmacinfo!
I've removed the link to the search form and fixed the reference to the existing ID of the containing div.
This is now merged to the Bluecheese 2.x branch and it will go to new.drupal.org in the next deployment that we do. Automatically closed - issue fixed for 2 weeks with no activity.
- 🇨🇦Canada xmacinfo Canada
The fix works, but semantically, we should fix the underlying page HTML.
The
<div id="content" class="content__area clearfix">
wraps the whole page, including the header, the main menu. The only thing it excludes is the footer.So, the skip link does nothing, since the
id="content"
wraps everything in.To fix this we need to add a
main-content
id where the actual content starts.So, there two things we can do going forward:
1. Remove the skip link
2. Keep the fix link, but fix the target to something likeid="main-content"
, where the actual content starts.I cannot reopen the ticket, so we will need to create a new ticket.
- 🇨🇦Canada xmacinfo Canada
Thanks for the reopen.
Can you identify which div (with or without an id) that contains the official start of the content?
- 🇪🇸Spain fjgarlin
I just checked this again and I think that the current implementation is correct.
The header and the footer are outside the main content area. The main menu is outside, but visually is on top of the content, and the content has padding on top to accommodate for this.
I'm going to mark it as "Fixed" again as I think this is what is expected.
Automatically closed - issue fixed for 2 weeks with no activity.