The active workspace is not persisted for the entire lifecycle of a form

Appears to have a number of test failures.

No more test failures :)

Think there may have been a rebase issue?

@smustgrave, not sure why you think so, the MR was applying just fine. Merged the latest 11.x though just in case.

So why are the changes to the gitlab file, link module, file discovery, etc needed?

Like its merging in other stuff

amateescu → closed merge request !12180

Oops, I wasn't looking at the changes tab. Not sure what happened there but I couldn't do anything with that branch so I opened a new MR instead.

Since this is an API change probably needs a CR

Added a CR.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

CRs seem fine to me. Believe all feedback has been addressed here

When I look at this I keep thinking there must be a better way to do it, but I don't think one exists - e.g. it might be good if we could make ajax_page_state extensible and put other things in there that always have to be passed around to various AJAX requests but it's not. Given this is self-contained in the workspaces module, going to go ahead and commit this and if a centralised way shows up later we can eventually convert over to that.

Committed/pushed to 11.x and cherry-picked to 11.2.x, thanks!

catch → closed merge request !12283