- Issue created by @Grevil
- 🇩🇪Germany jan kellermann
You are using "module" for type-attribute. I suspect that this can cause the problem. I have to check later.
- 🇩🇪Germany jan kellermann
I added the handling for given type.
Can you please test, review and feedback?
Thank you!
- 🇩🇪Germany Anybody Porta Westfalica
Nice finding @jan kellermann that looks promising and totally makes sense! Thank you for the super quick reply!
- 🇩🇪Germany Grevil
Ok, the script is present now! Unfortunately at the time, that the vidstack player gets initiated, klaro hasn't finished processing the script yet, and therefore we still have the same warning in the console output:
Uncaught Vidstack Player JS library could not be loaded.
So if klaro is present, we somehow need to wait for klaro until we can fire our script. I tried to add klaro/klaro as a dependency to our script, but it doesn't seem to fix the problem...
@anybody, any idea? Should we continue with this problem in the vidstack_player module?
- 🇩🇪Germany Anybody Porta Westfalica
No idea yet, sorry. Sounds like some kind of race condition / timing issue...
- 🇩🇪Germany jan kellermann
I have the same problem without klaro but bigpipe enabled.
Maybe change your loading pattern like this?
https://git.drupalcode.org/project/klaro/-/merge_requests/58.diff - 🇩🇪Germany jan kellermann
@sascha_meissner: I replaced
application/javascript
withtext/javascript
. Can you please test again?@anybody / @grevil: Did you check my suggestions to avoid race conditions in vidstack_player? Maybe you can review this issue also?
- 🇩🇪Germany sascha_meissner Planet earth
Reviewed and tested, Looking great for me :)
- 🇩🇪Germany jan kellermann
The fix is merged.
Thank you all for fixing this issue. -
jan kellermann →
committed c1ff7415 on 3.x
#3521502: Keep the type attribute.
-
jan kellermann →
committed c1ff7415 on 3.x
- Status changed to Fixed
4 days ago 11:19am 27 June 2025 Automatically closed - issue fixed for 2 weeks with no activity.