- Issue created by @dww
- Merge request !11936Resolve #3521059 "Finish deprecating 'Update Manager' related code in Update Status" โ (Open) created by dww
- ๐บ๐ธUnited States dww
Thanks! Applied suggestions. Leaving the thread about moving the test into a new class open to see if anyone else has a strong opinion.
- ๐บ๐ธUnited States smustgrave
Thanks to our new gitlab bug I can't drill down into the test failures.
- ๐บ๐ธUnited States dww
There are no failures. The failure was the pipeline never started. Longwave and Drumm seem to have sorted it out.
Iโll push a no-op commit to hopefully trigger a new pipeline. - ๐บ๐ธUnited States dww
Yay, the pipeline really ran. However, there seem to be failures, after all. ๐ Iโll look more closely when Iโm at my laptop.
- ๐บ๐ธUnited States dww
Was calling the deprecated method from hook cron, which caused any tests that enable update.module and invoke cron to trigger deprecation notices. Removed that from cron, and now the pipeline is all green. Back to NR.
- ๐บ๐ธUnited States nicxvan
What is the full status of this initiative? Does this change need a CR?
If this piece is just clean up then I think we're ok, however, since we're deprecating things I think we need to notify people that disk cleanup won't happen anymore. - ๐บ๐ธUnited States dww
All the new deprecations reference the CR from the parent issue. If weโre happy and this lands, Iโll update that CR to mention these other deprecations. Assuming this ships in 11.2, seemed silly to use a separate CR for it. See the parent issue and linked CR for more.
Thanks!
-Derek - ๐บ๐ธUnited States dww
p.s. This specific disk cache cleanup method is only cleaning up a cache of tarballs downloaded for the deprecated and removed โUpdate Managerโ stuff. So nothing would be populating this cache, so no need to garbage collect it.
- ๐บ๐ธUnited States nicxvan
12 answers my question, I thought that was true, but wanted confirmation.
- ๐บ๐ธUnited States dww
To make #11 explicit, adding the tag. I hereby solemnly swear to make the updates once this is committed...
- ๐บ๐ธUnited States dww
Added a remaining task, probably for release managers:
Decide if we should explicitly mark the
allow_authorize_operations
setting itself deprecated insites/default/default.settings.php
andcore/assets/scaffold/files/default.settings.php