Finish deprecating 'Update Manager' related code in Update Status

Created on 24 April 2025, 2 days ago

Problem/Motivation

While grepping for ๐Ÿ“Œ Rename update module back to Update Status Active and looking around, I noticed a few more spots in core/modules/update that are code for the old authorize.php 'Update Manager' that we missed during ๐Ÿ“Œ Deprecate authorize.php and the FileTransfer system Active

Steps to reproduce

Proposed resolution

Deprecate the following:

  1. The update.root service and src/UpdateRoot.php
  2. _update_manager_extract_directory()
  3. _update_manager_cache_directory()
  4. update_clear_update_disk_cache()
  5. update_delete_file_if_stale()

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

๐Ÿ“Œ Task
Status

Active

Version

11.0 ๐Ÿ”ฅ

Component

update.module

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States dww

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dww
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States dww
  • Pipeline finished with Failed
    2 days ago
    Total: 189s
    #481510
  • Pipeline finished with Failed
    2 days ago
    Total: 203s
    #481527
  • Pipeline finished with Failed
    2 days ago
    Total: 183s
    #481530
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States nicxvan

    Minor comments.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States dww

    Thanks! Applied suggestions. Leaving the thread about moving the test into a new class open to see if anyone else has a strong opinion.

  • Pipeline finished with Failed
    2 days ago
    #481658
  • Pipeline finished with Failed
    2 days ago
    Total: 159s
    #481665
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    Thanks to our new gitlab bug I can't drill down into the test failures.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States dww

    There are no failures. The failure was the pipeline never started. Longwave and Drumm seem to have sorted it out.
    Iโ€™ll push a no-op commit to hopefully trigger a new pipeline.

  • Pipeline finished with Failed
    1 day ago
    Total: 782s
    #482121
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States dww

    Yay, the pipeline really ran. However, there seem to be failures, after all. ๐Ÿ˜‚ Iโ€™ll look more closely when Iโ€™m at my laptop.

  • Pipeline finished with Success
    1 day ago
    Total: 5228s
    #482183
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States dww

    Was calling the deprecated method from hook cron, which caused any tests that enable update.module and invoke cron to trigger deprecation notices. Removed that from cron, and now the pipeline is all green. Back to NR.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States nicxvan

    What is the full status of this initiative? Does this change need a CR?
    If this piece is just clean up then I think we're ok, however, since we're deprecating things I think we need to notify people that disk cleanup won't happen anymore.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States dww

    All the new deprecations reference the CR from the parent issue. If weโ€™re happy and this lands, Iโ€™ll update that CR to mention these other deprecations. Assuming this ships in 11.2, seemed silly to use a separate CR for it. See the parent issue and linked CR for more.

    Thanks!
    -Derek

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States dww

    p.s. This specific disk cache cleanup method is only cleaning up a cache of tarballs downloaded for the deprecated and removed โ€œUpdate Managerโ€ stuff. So nothing would be populating this cache, so no need to garbage collect it.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States nicxvan

    12 answers my question, I thought that was true, but wanted confirmation.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States dww

    To make #11 explicit, adding the tag. I hereby solemnly swear to make the updates once this is committed...

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States dww

    Added a remaining task, probably for release managers:

    Decide if we should explicitly mark the allow_authorize_operations setting itself deprecated in sites/default/default.settings.php and core/assets/scaffold/files/default.settings.php

Production build 0.71.5 2024