Through 🐛 Unable to edit the formatter settings (Warning: Trying to access array offset on null in Drupal\field_ui\Form\EntityDisplayFormBase->copyFormValuesToEntity()) Active and https://git.drupalcode.org/project/leaflet/-/commit/099db9b I saw that the methods in the formatters / Trait are missing the parent:: calls in all relevant functions!
This is important because we lose their implementation, at least if they change.
Sadly that does not fix the parent issue, but should also be fixed and I think the Trait would be the right place, combined with
📌
VidstackPlayerFormatterTrait::getSharedSettings() should be called ::settingsForm()?
Active
Active
1.0
Code
We can not use the Trait unfortunately, as it doesn't implement "settingsForm" as stated there. But I agree, this should be fixed.