I just reviewed the trait code and I think for best practice trait implementation VidstackPlayerFormatterTrait::getSharedSettings() should be called ::settingsForm() and same for ::getSharedDefaultSettings?
The problem is, that the settings are not the same for both Formatters. Meaning we would need to rename the "settingsForm" method on import for one of them anyway.
We should leave it as is.