- Issue created by @longwave
- Merge request !855Issue #3517455: Convert all plugins to use attributes over annotations โ (Merged) created by meghasharma
- ๐ฎ๐ณIndia meghasharma
Converted all ConfigEntityType plugins to use PHP 8 attributes instead of annotations.
- ๐ช๐ธSpain penyaskito Seville ๐, Spain ๐ช๐ธ, UTC+2 ๐ช๐บ
That rebase went bad. Lots of unrelated changes.
Hello @penyaskito,
Thank you for your feedback. Could you please clarify which unrelated changes you are referring to in MR !855? When I check the MR, I see only 5 files changed, which I believe are related to the issue. I'd really appreciate any specific pointers so I can correct it properly.- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
wim leers โ made their first commit to this issueโs fork.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
@utkarsh_kumar_singh Yep, looking good now! ๐๐
Fixed a few nits, but I believe the remaining feedback is actionable for you :)
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Also: not all plugin annotations have been converted. For example:
\Drupal\experience_builder\Entity\Page
's. Hello @wim leers,
Thank you for your suggestion, and apologies for the delay. I've implemented the suggested changesโplease review.- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
penyaskito โ credited larowlan โ .
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
It will be so nice to have this in! :D
And given it's a long weekend for many, I'm prioritizing this landing today to minimize overall disruption.
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Thanks to @penyaskito, I was able to open ๐ ContentCreatorVisibleXbConfigEntityAccessControlHandler's `view` access must refuse access to disabled config entities Active .
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
wim leers โ changed the visibility of the branch 0.x to hidden.
-
wim leers โ
committed db66853d on 0.x authored by
meghasharma โ
Issue #3517455 by wim leers, utkarsh_kumar_singh, longwave, penyaskito,...
-
wim leers โ
committed db66853d on 0.x authored by
meghasharma โ
Automatically closed - issue fixed for 2 weeks with no activity.