- Issue created by @longwave
- Merge request !855Issue #3517455: Convert all plugins to use attributes over annotations → (Open) created by meghasharma
- 🇮🇳India meghasharma
Converted all ConfigEntityType plugins to use PHP 8 attributes instead of annotations.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
That rebase went bad. Lots of unrelated changes.
Hello @penyaskito,
Thank you for your feedback. Could you please clarify which unrelated changes you are referring to in MR !855? When I check the MR, I see only 5 files changed, which I believe are related to the issue. I'd really appreciate any specific pointers so I can correct it properly.- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
wim leers → made their first commit to this issue’s fork.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@utkarsh_kumar_singh Yep, looking good now! 👍😄
Fixed a few nits, but I believe the remaining feedback is actionable for you :)
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Also: not all plugin annotations have been converted. For example:
\Drupal\experience_builder\Entity\Page's. Hello @wim leers,
Thank you for your suggestion, and apologies for the delay. I've implemented the suggested changes—please review.
