Set Tagify widget as default when a new entity reference field is created

This is looking good to me, the only suggestion is to add an update hook to the next release of the tagify module which sets the default value for existing sites.

Thanks Jurgen for the quick feedback!

The goal is to set set_default_widget to TRUE in Drupal CMS, which will be implemented through this issue. Given this, I don’t see the need for the hook.

In the Tagify module itself, I would keep the option set to FALSE, allowing users to decide whether to enable it as the default.

But, maybe I'm not seeing something.

@gxleano the problem with the implementation in ✨ Add a setting form where Tagify widget can be set as default when a supported field is created Active is that it works for new Drupal installations, whether Drupal CMS or vanilla Drupal. But if an existing site, that already has tagify enabled, will not have any setting for set_default_widget, neither true nor false. That may create PHP warnings when using the return value from $config->get('set_default_widget'), as it's expected to be TRUE or FALSE, but you may get NULL instead.

Therefore, adding an update hook in the module, which will only be executed on existing sites when updating to the latest tagify version, you can make sure to initialize that new config value. New installations of Drupal CMS will not be affected by that, so that they will receive the default value from the recipe, which is fine.

Now I see!

It totally makes sense.

Thanks Jurgen.

When a recipe installs a module, the simple config from that module is imported. So you can't import your own version of that config because it will already exist. Failures abound, config explosions everywhere!%&#@^&$^&!

Instead, in each of the recipe's config actions section, use the simpleConfigUpdate action to rewrite them.

config:
  actions:
    tagify.settings:
      simpleconfigUpdate:
        set_default_widget: true

I'd love to get this committed today, because we're intending to roll Drupal CMS 1.1.0 this week and it would be great to have this in by then.

Thanks @thejimbirch, it was also a suggestions by @plopesc, so I will update it.

I will finish this today @phenaproxima.

Changes looks good. Marking as RTBC assuming the tests pass.

Looks great y'all. Merged into 1.x. Thanks!

This will need to be mentioned in the change record for ✨ Enable Tagify in Admin UI recipe Active , so tagging accordingly. We won't need a separate change record, but we need to remember to describe the changes in this issue, in that change record.

Created the change record, it just needs details filled in. https://git.drupalcode.org/project/drupal_cms/-/wikis/Committer-Info/Cha... can be used as a template.

I was blown away to see this already working in 1.x! So cool to get these minor but so important improvements happening :)

Do we definitely need a CR for this? Tagify is added in the same release as this change.

Didn't read the comments properly, I've updated the CR with info.

Change record updated and published.

Automatically closed - issue fixed for 2 weeks with no activity.