- Issue created by @wim leers
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
To get a list of the remaining work, force XB to pretend we're at 100%:
$ git diff diff --git a/tests/src/Kernel/EcosystemSupport/FieldTypeSupportTest.php b/tests/src/Kernel/EcosystemSupport/FieldTypeSupportTest.php index 878776835..dedb9ea82 100644 --- a/tests/src/Kernel/EcosystemSupport/FieldTypeSupportTest.php +++ b/tests/src/Kernel/EcosystemSupport/FieldTypeSupportTest.php @@ -48,12 +48,12 @@ final class FieldTypeSupportTest extends EcosystemSupportTestBase { /** * The known current % of supported field types. */ - public const COMPLETION = 0.7419354838709677; + public const COMPLETION = 1; /** * The known current % of supported field type props. */ - public const COMPLETION_PROPS = 0.6274509803921569; + public const COMPLETION_PROPS = 1; /** * Supported field types (keys), with explicitly unsupported props (values).
ā¦ and then you'll get explicit test failures:
1) Drupal\Tests\experience_builder\Kernel\EcosystemSupport\FieldTypeSupportTest::test Not yet supported: test_optional__decimal, test_optional__language, test_optional__list_string, test_optional__map, test_optional__telephone, test_optional__text, test_optional__text_long, test_optional__text_with_summary, test_required__decimal, test_required__language, test_required__list_string, test_required__map, test_required__telephone, test_required__text, test_required__text_long, test_required__text_with_summary Failed asserting that 0.7419354838709677 is identical to 1.
and
1) Drupal\Tests\experience_builder\Kernel\EcosystemSupport\FieldTypeSupportTest::test Not yet supported: test_optional__comment.last_comment_name, test_optional__decimal.value, test_optional__language.language, test_optional__language.value, test_optional__list_string.value, test_optional__password.existing, test_optional__password.value, test_optional__telephone.value, test_optional__text.format, test_optional__text.processed, test_optional__text.value, test_optional__text_long.format, test_optional__text_long.processed, test_optional__text_long.value, test_optional__text_with_summary.format, test_optional__text_with_summary.processed, test_optional__text_with_summary.summary, test_optional__text_with_summary.summary_processed, test_optional__text_with_summary.value, test_required__comment.last_comment_name, test_required__decimal.value, test_required__language.language, test_required__language.value, test_required__list_string.value, test_required__password.existing, test_required__password.value, test_required__telephone.value, test_required__text.format, test_required__text.processed, test_required__text.value, test_required__text_long.format, test_required__text_long.processed, test_required__text_long.value, test_required__text_with_summary.format, test_required__text_with_summary.processed, test_required__text_with_summary.summary, test_required__text_with_summary.summary_processed, test_required__text_with_summary.value Failed asserting that 0.6274509803921569 is identical to 1.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
So, with #6, we've got a way to list the remaining work, to achieve @lauriii's stated goal of supporting ALL core field types + widgets.
It also empowers @lauriii to decide which field types, field type props and field widgets we'll intentionally exclude from scope. (i.e. won't work on adding support for)
It'll get surfaced in a more accessible form in š CI: surface the list of field types, field type props and field widgets not yet supported by XB Active .
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Follow-ups, now all linked:
- š Provide visibility into field types with different matching SDC prop shapes depending on field storage settings Active
- š CI: surface the list of field types, field type props and field widgets not yet supported by XB Active
- āØ Do we want to support the `link` field type's `options` prop? Active
- š Mark two more core field type's computed properties as internal Active
- š Find bug(s) that explain unmatched field type props Active
And some of the core bugs surfaced here actually have been known for years: I opened š [PP-1] Convert field_storage_config and field_config's form validation logic to validation constraints Postponed in November 2022 š
-
wim leers ā
committed f7d251a9 on 0.x
Issue #3512433 by wim leers: Provide visibility into which (core) field...
-
wim leers ā
committed f7d251a9 on 0.x
Automatically closed - issue fixed for 2 weeks with no activity.