Mark two more core field type's computed properties as internal

Created on 13 March 2025, about 1 month ago

Overview

๐Ÿ“Œ Provide visibility into which (core) field type props can be mapped into Content Type Templates vs not Active added FieldTypeSupportTest identified that while the daterange field type is supported, its start_date and end_date properties cannot be currently mapped into any SDC.

Turns out that that is okay, because it's used only internally, and the value and end_value twin values already contain the same data, and those can be mapped! ๐Ÿ‘ Hence start_date and end_date were marked as internal.

The same problem was identified for the following field type's properties:

  • datetime's date
  • file_uri's url

Proposed resolution

Apply the same pattern to

  • datetime's date
  • file_uri's url

User interface changes

None.

๐Ÿ“Œ Task
Status

Active

Version

0.0

Component

Page builder

Created by

๐Ÿ‡ง๐Ÿ‡ชBelgium wim leers Ghent ๐Ÿ‡ง๐Ÿ‡ช๐Ÿ‡ช๐Ÿ‡บ

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @wim leers
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia meghasharma

    Working on it.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia meghasharma

    Marked 'date' (DateTimeItem) and 'url' (FileUriItem) properties as internal
    Created DateTimeItemOverride.php to override DateTimeItem and marked the date property as internal.
    Updated FileUriItemOverride.php (already present) to mark the url property as internal.
    Please review

  • Pipeline finished with Failed
    27 days ago
    Total: 1890s
    #453246
  • ๐Ÿ‡ง๐Ÿ‡ชBelgium wim leers Ghent ๐Ÿ‡ง๐Ÿ‡ช๐Ÿ‡ช๐Ÿ‡บ
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia meghasharma

    This is already implemented in the file. The datetime fieldโ€™s date and the file_uri fieldโ€™s url are handled the same way as daterange in tests/src/Kernel/EcosystemSupport/FieldTypeSupportTest.php.

    'datetime' => [  
      // ๐Ÿ› Core bug: this is the computed equivalent of `value`, should be marked internal.  
      // @todo Give this similar treatment as `daterange` in https://www.drupal.org/project/experience_builder/issues/3512853  
      'date' => FALSE,  
    ],  
    'file_uri' => [  
      // ๐Ÿ› Core bug: this is the computed equivalent of `value`, should be marked internal.  
      // @todo Give this similar treatment as `daterange` in https://www.drupal.org/project/experience_builder/issues/3512853  
      'url' => FALSE,  
    ],  
    

    Let me know if anything else is needed. Thanks!

  • Pipeline finished with Failed
    26 days ago
    Total: 2557s
    #453775
  • Pipeline finished with Failed
    26 days ago
    Total: 2493s
    #453816
Production build 0.71.5 2024