- Issue created by @wim leers
- Merge request !805Issue #3512853: Mark two more core field type computed properties as internal. โ (Open) created by meghasharma
- ๐ฎ๐ณIndia meghasharma
Marked 'date' (DateTimeItem) and 'url' (FileUriItem) properties as internal
Created DateTimeItemOverride.php to override DateTimeItem and marked the date property as internal.
Updated FileUriItemOverride.php (already present) to mark the url property as internal.
Please review - ๐ฎ๐ณIndia meghasharma
This is already implemented in the file. The datetime fieldโs date and the file_uri fieldโs url are handled the same way as daterange in tests/src/Kernel/EcosystemSupport/FieldTypeSupportTest.php.
'datetime' => [ // ๐ Core bug: this is the computed equivalent of `value`, should be marked internal. // @todo Give this similar treatment as `daterange` in https://www.drupal.org/project/experience_builder/issues/3512853 'date' => FALSE, ], 'file_uri' => [ // ๐ Core bug: this is the computed equivalent of `value`, should be marked internal. // @todo Give this similar treatment as `daterange` in https://www.drupal.org/project/experience_builder/issues/3512853 'url' => FALSE, ],
Let me know if anything else is needed. Thanks!