Markup is escaped in slots

I am OK with the MR but I am surprised we let this happens. Maybe it was done in purpose and we forgot, let's be careful and think twcie before merging.

Hm I think it is simple a bug. When you use embed or extends it works as expected. Maybe we introduced "include" later and never checked that.

Ok great

Hi there, we need more tests to cover that case and the other mentioned.
let's add tests with the fix and then we can merge :) what do you think?

Also, i would say "#markup" won't cover all possible html content, but will rather let some tags be accepted and some other not.
for example, i guess input would be filtered. So why not "#children" if we want any html tag to be accepted?

So why not "#children" if we want any html tag to be accepted?

If my understanding is right, #children is an internal render property of the renderer service and we are not expected to use it in our code.

I will check

As I understand we need either #markup => Markup::create($markup) or #children

And are there tests for the include function?

christian,

What about doing that?

{% set content %}
<div>My Markup</div>
{%endset %}

{{ include("my:component", {
  content: {
    '#markup': content
  }}) }} 

Thats wrong. Nobody will understand it:).

Why not use #children as 3 lines above.

i have better.
we need to introduce a new condition. the string here is injected as an object \Twig\Markup
and is an instance of \Stringable.
we should make a new condition in SlotPropType to allow those twig markup to be properly treated as Markup from the render array point of view, while we don't change what we have for the other \Stringable objects.
i will also add a a test for that.
let me push something

Thats wrong. Nobody will understand it:).

You are talking about presenter templates, right? Nobody understand them already :) and they will disappear soon hopefully. that's why we are extra careful and future-proofing in SDC templates, but we care less in presenter templates.

Why not use #children as 3 lines above.

I still believe #children is an internal property of the render API and we are not supposed to use it.

Except 3 messy snippets, it is used by Drupal Core only in the Render API internals:

• web/core/modules/views_ui/src/ViewEditForm.php
• web/core/modules/layout_builder/src/Controller/ChooseSectionController.php
• web/core/modules/system/src/Controller/DbUpdateController.php
• web/core/lib/Drupal/Core/Render/Renderer.php (many times!)
• web/core/includes/form.inc (many times!)
• web/core/includes/theme.inc (a few times)

than #markup = Markup::create() instead of #children?

Christian,
would you review my new MR please :)
MR !345 (mergeable)

@christian.wiedemann thanks so much for this patch. We use this pattern all over the place, and it breaks when I install ui_patterns.

This is a similar pattern which was also broken by ui_patterns and is fixed by this patch:

modal.twig

<div>
  <div class="modal--body>
    {% block modal_body %}{% endblock %}
  </div>
</div>

mobile_header.twig

        {% set modal_body %}
          {% block modal_languages %}{% endblock %}
        {% endset %}
        {% embed 'my_components:modal' %}
          {% block modal_body %}{{ modal_body }}{% endblock %}
        {% endembed %}

that one is indeed a nice one to have :)
can't wait for the new 2.0.1 tag

A similar issue: 🐛 Property values are converted to Markup Active

Automatically closed - issue fixed for 2 weeks with no activity.