Pause Ad Banner or hide

May be adding a none option in size?

I thing the banner size is a way to select a kind of block to show it. So if I have the option to select nothing the banner will not appear but will be create.

We need to show the "status" (published) checkbox in our default form display.

Part of our 11.x efforts, so it will be a follow-up to 📌 [META] 11.x feature updates Active .

Hi
I have tested MR 8 on Drupal 11.x
The MR is applied successfully...

By default "status" (published) checkbox is available for add and edit form.

RTBC+1

LGTM and works as expected. But there are two points to talk about:

1. Should we really use a yaml definition to define the form of the ad content entities? Should we instead create a new AdContentForm extending "ContentEntityForm" and use that instead? So we have the form definition baked in code instead of defining it through a yml?
2. Do we need an update hook here? The new checkbox won't appear for existing installations. Do we want 11.x to be backwards compatible? Probably right?

What do you think @anybody?

Wonderful, this is the correct fix. We need no update hook I think, as this would (possibly unexpectedly) change existing installations. New installations should be fine now.

As stated above:

The new checkbox won't appear for existing installations.

meaning if we need backwards compatibility, this patch alone won't do it.

Nope that's not needed. It's just a feature request, not a bug. Anyone who wanted it, was and is able to enable it. This is just for better default behaviour and convenience :)