- Issue created by @quietone
- πΊπΈUnited States smustgrave
Did a simple search in phpstorm for
{ return parent::
And found 90ish more instances for example in ActionPluginCollection, InstallerKernel
So what should the scope of this issue be? Is there a rule we could enable?
- π³πΏNew Zealand quietone
This part of enabling"Generic.CodeAnalysis.UselessOverridingMethod", which is in the Problem/Motivation section.
The scope is correct, it is fixing the instances where an unnecessary override was detected by the sniff. There is no change to phpcs.xml.dist because of remaining overrides, which are not unnecessary, will require discussion, and span the code base.
- πΊπΈUnited States smustgrave
Not sure then, there are other instances in the repo
- π§πͺBelgium borisson_ Mechelen, π§πͺ
Doing the complete thing is going to require a lot of discussion, these are all very straight forward. It already improves the state of the codebase. Ship it.
- π¬π§United Kingdom catch
If this makes the sniff pass then it's fine - we should go ahead, then it will stop new ones creeping in.
If there are other cases in core that aren't picked up by the sniff, that's a good follow-up.
Committed/pushed to 11.x, thanks!