Add complete tests coverage of module's code base

Quick follow-up on this issue:

Created initial merge request MR!7 above at #2 ✨ Add complete tests coverage of module's code base Active to:

Add complete tests coverage of module's code base, as described in the issue summary, see Functional tests class: LoginSwitchTest.

Additional changes:

• Moved Login switch settings form under Configuration > People, changed path and access requirements.
• Removed event subscriber ExceptionEventSubscriber causing drupalLogout to fail in test case.
• Removed useless test class LoadTest.

 
These changes have been tested on Gitlab CI and come back green 🟢
https://git.drupalcode.org/issue/login_switch-3497745/-/pipelines/428721

thus moving issue to Needs review.

We would greatly appreciate if a maintainer with write access could take a look at merge request MR!7 and let us know if any more work would be required to improve module's automated tests coverage.

Feel free to let us know if you would have any questions or concerns on any aspects of this issue or the project in general, we would surely be glad to help.
Thanks in advance!

Rebased MR!7 with the latest changes and in particular integration with GitlabCI pipeline:

Tests are passing all GREEN 🟢 for D10:
https://git.drupalcode.org/issue/login_switch-3507900/-/pipelines/429981

Let me know Matthew (@drupalmatts) if you have any questions concerning the removed files, in particular src/Routing/ExceptionEventSubscriber.php, or the changes to the menu link/route for the admin settings form, I'd be very happy to explain and provide more details.

Thanks again for your help !
Cheers !

Honestly this is one of the most relevant contrib module i used! . I would like to work on any part of the module or feature integrations :).

I will check the testcases soon. Thanks @dydave and @drupalmatts

one doubt is that this MR need to be merged against 3.x right? which supports for D9 and 10.

Thanks Muneeb (@mukhtarm)!

I've been asking Matthew (@drupalmatts) several times about the confusing development branches, see:

#3499850-5: Add module configuration schema file → :

What's the plan with the different branches?
Could we maybe remerge 8.x-dev into 3.x and move developments into 3.x?

This would simplify the understanding of module's code base and be more consistent with the stable version names, for example 3.0.3:
https://www.drupal.org/project/login_switch/releases/3.0.3 →

For the time being, I'll try creating MRs for the 8.x-dev branch.

and #3497745-7: Automated testing: Configure GitLab CI → :

==> the dev branches are confusing ... for creating MRs and such...

Since I saw changes in other tickets getting merged in the 8.x-dev branch, I opted to create merge requests against this branch for now.

I have already made several suggestions to try to clarify module's code base.

Hopefully we should be able to get a reply when module's maintainer gets some time.
Otherwise, any feedback, suggestions or comments on any of the pending tickets would certainly be greatly appreciated.
Thanks in advance.

Team... i will look at the branches and adjust as appropriate in the drupal guidelines. Sorry about the numbering.

Thanks Matthew (@drupalmatts)!

Would be happy to help with the code base and all the tickets if you are kept busy with projects.
Feel free to take a look at 📌 Offering to co-maintain Login Switch Active , when you get some time.

Thanks in advance!

Super nice Matthew (@drupalmatts)!
Thanks a LOT!! 🙏

Thank you so much for the credit, it's super appreciated!

Automatically closed - issue fixed for 2 weeks with no activity.